New issue
Advanced search Search tips

Issue 688060 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert ConvolverNode tests to testharness

Project Member Reported by rtoy@chromium.org, Feb 2 2017

Issue description

Update tests to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4726f5b6b18b3ae44776ec2440248f96230a6eab

commit 4726f5b6b18b3ae44776ec2440248f96230a6eab
Author: rtoy <rtoy@chromium.org>
Date: Thu Feb 02 23:26:00 2017

Convert ConvolverNode tests to testharness

Convert tests to use testharness.  convolver-channels.html was
converted by script but also needed a small manual change because of
testPassed/testFailed, but was otherwise unchanged.

The other tests were converted by hand.

BUG= 688060 
TEST=convolution-mono-mono.html, convolver-channels.html,
convolver-setBuffer-null.html

Review-Url: https://codereview.chromium.org/2669293002
Cr-Commit-Position: refs/heads/master@{#447872}

[delete] https://crrev.com/e900021031992c3acd78379a1cd0994039fd7bd8/third_party/WebKit/LayoutTests/webaudio/Convolver/convolution-mono-mono-expected.txt
[modify] https://crrev.com/4726f5b6b18b3ae44776ec2440248f96230a6eab/third_party/WebKit/LayoutTests/webaudio/Convolver/convolution-mono-mono.html
[delete] https://crrev.com/e900021031992c3acd78379a1cd0994039fd7bd8/third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels-expected.txt
[modify] https://crrev.com/4726f5b6b18b3ae44776ec2440248f96230a6eab/third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html
[delete] https://crrev.com/e900021031992c3acd78379a1cd0994039fd7bd8/third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-setBuffer-null-expected.txt
[modify] https://crrev.com/4726f5b6b18b3ae44776ec2440248f96230a6eab/third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-setBuffer-null.html
[modify] https://crrev.com/4726f5b6b18b3ae44776ec2440248f96230a6eab/third_party/WebKit/LayoutTests/webaudio/resources/convolution-testing.js

Comment 2 by rtoy@chromium.org, Feb 3 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Comment 3 by rtoy@chromium.org, Feb 3 2017

Blocking: 623160

Sign in to add a comment