New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 688058 link

Starred by 1 user
Status: Fixed
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
engedy@chromium.org
█ rsch...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add support for disabling subresource filtering on reload

Project Member Reported by bmcquade@chromium.org, Feb 2 2017 
On rare occasions, subresource filtering may break a web page. In these cases, users may reload the page, since users commonly reload when a page is broken. Thus, we should consider either always disabling subresource filtering on reload, or if this isn't a good default, we should make it possible to disable on reload via a field trial param.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0766bcb584f9dc069573be95e06e019b37d280e0

commit 0766bcb584f9dc069573be95e06e019b37d280e0
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Feb 08 21:14:01 2017

Disable subresource filtering on page reloads.

BUG= 688058 

Review-Url: https://codereview.chromium.org/2667303003
Cr-Commit-Position: refs/heads/master@{#449091}

[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/content/browser/BUILD.gn
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/content/browser/DEPS
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/core/browser/subresource_filter_features.h
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/core/browser/subresource_filter_features_test_support.h
[modify] https://crrev.com/0766bcb584f9dc069573be95e06e019b37d280e0/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc

Comment 2 by bmcquade@chromium.org, Feb 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment