New issue
Advanced search Search tips

Issue 688052 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Closing context should not set destination to null

Project Member Reported by rtoy@chromium.org, Feb 2 2017

Issue description

Resolution of https://github.com/WebAudio/web-audio-api/issues/1099 implies that Chrome should not set the AudioContext destination to null.  This preserves the sampleRate.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by rtoy@chromium.org, Mar 7 2018

Status: Available (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbeb7bf25a794a2d482e56faab4577b09a36c9d5

commit fbeb7bf25a794a2d482e56faab4577b09a36c9d5
Author: Hongchan Choi <hongchan@chromium.org>
Date: Fri Jun 29 01:08:08 2018

Add AudioContext::ContextDestroyed

Currently AudioContext has no way of uninitializing the instance without
an explicit context closure. This extends BaseAudioContext's
ContextDestroyed to AudioContext so we can hook up its own uninitialize
routine, and then eventually calls the parent's uninitializer.

This also fixes other issue of UKM metrics being reported in less cases
because they were only reported when context.close() was called.

Bug:  856690 ,  688052 ,  670065 
Change-Id: I721dc2c27201caab1b0a95baf8f6906f44b76979
Reviewed-on: https://chromium-review.googlesource.com/1115516
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571349}
[modify] https://crrev.com/fbeb7bf25a794a2d482e56faab4577b09a36c9d5/third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-close.html
[modify] https://crrev.com/fbeb7bf25a794a2d482e56faab4577b09a36c9d5/third_party/blink/renderer/modules/webaudio/audio_context.cc
[modify] https://crrev.com/fbeb7bf25a794a2d482e56faab4577b09a36c9d5/third_party/blink/renderer/modules/webaudio/audio_context.h
[modify] https://crrev.com/fbeb7bf25a794a2d482e56faab4577b09a36c9d5/third_party/blink/renderer/modules/webaudio/base_audio_context.cc
[modify] https://crrev.com/fbeb7bf25a794a2d482e56faab4577b09a36c9d5/third_party/blink/renderer/modules/webaudio/base_audio_context.h

Status: Fixed (was: Available)

Sign in to add a comment