Info message above keyboard overlay has orange/red border around it |
||||||
Issue descriptionChrome Version: 56.0.2924.87 OS Version: 9000.81.0 The "Hold Control, Alt, Shift, ..." box displayed above the Ctrl+Alt+/ keyboard overlay has a weird one-pixel orange/red border around it when the overlay is first displayed. It goes away if you press and release a modifier. I'm unable to take a screenshot of this (since the screenshot accelerator makes the box go away). I suspect that it's a focus ring. I'm not sure who, if anyone, owns this now. Fixing it is hopefully just a matter of tweaking some CSS.
,
Feb 2 2017
This is the default focus ring. We manually request to focus that element specifically for chrome vox to start reading the instructions, otherwise it will start reading keys in random order. I can change the style of the focus ring. Do we want to do that?
,
Feb 2 2017
Your phone has a better camera than mine. :-) Yes, I think it makes sense to hide the focus ring in this case. I don't think that any interaction with the message (or any other part of the overlay) is possible, and the ring looks strange as well (e.g. it doesn't follow the box's rounded corners).
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccfadbad03c399f42543a9ea45d1748a85278216 commit ccfadbad03c399f42543a9ea45d1748a85278216 Author: afakhry <afakhry@chromium.org> Date: Mon Feb 06 23:06:41 2017 Remove the ugly focus outline of the keyboard overlay instructions The instructions div of the keyboard overlay is programmaticllay focused when the widget is shown to enable chrome vox to read it the first thing, however the default style of a focused element is to show an ugly orange outline around it. This CL removes that outline. BUG= 688016 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2679563003 Cr-Commit-Position: refs/heads/master@{#448433} [modify] https://crrev.com/ccfadbad03c399f42543a9ea45d1748a85278216/chrome/browser/resources/chromeos/keyboard_overlay.css
,
Feb 7 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by zalcorn@chromium.org
, Feb 2 2017Owner: afakhry@chromium.org