Regression from pending navigation index feature.

Is it the same root cause as 688047 ?

cmasso@, it is unlikely have the same root cause as 688047.

Fix on review: https://codereview.chromium.org/2687343003/
its landing is blocked by navigation related bugs, which are being fixed by kkhorimoto

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2517f141263ee8913024a3a96cd909423ad7214

commit b2517f141263ee8913024a3a96cd909423ad7214
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Feb 14 03:21:43 2017

Fixed navigation for displayed SSL interstitials.

Navigation did not work for interstitials for 2 reasons which are fixed
in this CL:

1.) |WebInterstitialImpl::DontProceed| should not reload.
Reloading stops pending navigation and reloads last committed item,
which is not always correct target item. On other platforms
InterstitialPageImpl::DontProceed does not reload.

2.) |clearTransientContentView| removes pending item, so it should be
called before pending navigation is initiated. So next
|clearTransientContentView| call will be no-op.

This CL changes the behavior, so when user taps "BACK TO SAFETY" the page
is not reloaded. This is fine, but in order to update omnibox URL, tab
should subscribe to webStateDidDismissInterstitial: callback and update
the toolbar.

BUG= 677193 , 677190 , 688009 

Review-Url: https://codereview.chromium.org/2687343003
Cr-Commit-Position: refs/heads/master@{#450220}

[modify] https://crrev.com/b2517f141263ee8913024a3a96cd909423ad7214/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/b2517f141263ee8913024a3a96cd909423ad7214/ios/web/interstitials/web_interstitial_impl.mm
[modify] https://crrev.com/b2517f141263ee8913024a3a96cd909423ad7214/ios/web/web_state/ui/crw_web_controller.mm

This bug requires manual review: Less than 2 weeks to go before AppStore submit on M57
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Verified on M58.03013.0 canary
Device: iPhone7
iOS: 10.3

Taping on New tab redirects to New Tab page correctly.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9674693c37dc34ad55e2f21f19050ed2938d6d1c

commit 9674693c37dc34ad55e2f21f19050ed2938d6d1c
Author: eugenebut <eugenebut@chromium.org>
Date: Thu Feb 16 01:36:27 2017

Fixed navigation for displayed SSL interstitials.

Navigation did not work for interstitials for 2 reasons which are fixed
in this CL:

1.) |WebInterstitialImpl::DontProceed| should not reload.
Reloading stops pending navigation and reloads last committed item,
which is not always correct target item. On other platforms
InterstitialPageImpl::DontProceed does not reload.

2.) |clearTransientContentView| removes pending item, so it should be
called before pending navigation is initiated. So next
|clearTransientContentView| call will be no-op.

This CL changes the behavior, so when user taps "BACK TO SAFETY" the page
is not reloaded. This is fine, but in order to update omnibox URL, tab
should subscribe to webStateDidDismissInterstitial: callback and update
the toolbar.

BUG= 677193 , 677190 , 688009 
TBR=kkhorimoto@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2687343003
Cr-Commit-Position: refs/heads/master@{#450220}
(cherry picked from commit b2517f141263ee8913024a3a96cd909423ad7214)

Review-Url: https://codereview.chromium.org/2694623013
Cr-Commit-Position: refs/branch-heads/2987@{#537}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/9674693c37dc34ad55e2f21f19050ed2938d6d1c/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/9674693c37dc34ad55e2f21f19050ed2938d6d1c/ios/web/interstitials/web_interstitial_impl.mm
[modify] https://crrev.com/9674693c37dc34ad55e2f21f19050ed2938d6d1c/ios/web/web_state/ui/crw_web_controller.mm

The cherry pick seems to have had conflicts but the resolution breaks the build.

The CL:
https://codereview.chromium.org/2687343003
has less changes than the cherrypick:
https://paste.googleplex.com/6301052248784896

Fix is here: https://codereview.chromium.org/2698203004/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa2485e99f2a87ab0fe88e6185960c9a153f0e4f

commit aa2485e99f2a87ab0fe88e6185960c9a153f0e4f
Author: eugenebut <eugenebut@chromium.org>
Date: Thu Feb 16 19:01:23 2017

Fixed compilation after 688009 cherry-pick

The problem was caused by incorrect merge conflict resolution.

BUG= 688009 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2698203004
Cr-Commit-Position: refs/branch-heads/2987@{#552}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/aa2485e99f2a87ab0fe88e6185960c9a153f0e4f/ios/web/web_state/ui/crw_web_controller.mm

Verified the issue on the build 57.0.2987.72 beta tested on iPhone7+(iOS 10).
User is navigated to newtab on Taping on New tab,works fine