New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 688005 link

Starred by 1 user
Status: Fixed
Owner:
wychen@chromium.org
Closed: Feb 2017
Cc:
█ k...@chromium.org
mdjones@chromium.org
olivierrobin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Wrongly retained icon in <a> without href in <figcaption>

Project Member Reported by wychen@chromium.org, Feb 2 2017 
Example: https://www.foreignaffairs.com/articles/united-states/2017-01-20/jacksonian-revolt?cid=%3Fcid%3Demc-paywall_free-the_jacksonian_revolt-013017

The HTML is:
<figcaption>some text<a><svg></svg></a></figcaption>

That <svg> icon should not be extracted, since it is used to expand the caption text.
One possible fix is to ignore <a> without href, since they are not real links.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02aad1bec1531836b02ec1666d75f592cad6fc1d

commit 02aad1bec1531836b02ec1666d75f592cad6fc1d
Author: wychen <wychen@chromium.org>
Date: Wed Feb 15 23:00:01 2017

Roll DOM Distiller JavaScript distribution package

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/4540f3524d...5da487862e

Picked up changes:
5da4878 Skip non-text elements in <a> without href in <figcaption>
6bd2ebb Fix more partially hidden articles

BUG=687071, 688005 

Review-Url: https://codereview.chromium.org/2692853010
Cr-Commit-Position: refs/heads/master@{#450828}

[modify] https://crrev.com/02aad1bec1531836b02ec1666d75f592cad6fc1d/DEPS
[modify] https://crrev.com/02aad1bec1531836b02ec1666d75f592cad6fc1d/third_party/dom_distiller_js/README.chromium

Comment 2 by wychen@chromium.org, Feb 15 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a247732257db5f5046b8d5a5531c448e571985f

commit 1a247732257db5f5046b8d5a5531c448e571985f
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Thu Feb 16 17:56:24 2017

Roll DOM Distiller JavaScript distribution package

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/4540f3524d...5da487862e

Picked up changes:
5da4878 Skip non-text elements in <a> without href in <figcaption>
6bd2ebb Fix more partially hidden articles

BUG=687071, 688005 

Review-Url: https://codereview.chromium.org/2692853010
Cr-Commit-Position: refs/heads/master@{#450828}
(cherry picked from commit 02aad1bec1531836b02ec1666d75f592cad6fc1d)

Review-Url: https://codereview.chromium.org/2704533002 .
Cr-Commit-Position: refs/branch-heads/2987@{#550}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/1a247732257db5f5046b8d5a5531c448e571985f/DEPS
[modify] https://crrev.com/1a247732257db5f5046b8d5a5531c448e571985f/third_party/dom_distiller_js/README.chromium
►

Sign in to add a comment