New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687977 link

Starred by 1 user
Status: Fixed
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Feb 2017
Cc:
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Faded Action item when snippets reload during dismiss animation

Project Member Reported by dgn@chromium.org, Feb 2 2017 
Steps:
(0. Make sure there is only one section with an action item)
1. Dismiss items until the status card is visible
2. Press MORE
3. Swipe the status card towards the side until is is almost completely faded, but hold the finger there to keep it in this state.
4. Wait until the fetch starts at step 2 completes
5. Swipe cards to bring back the action item in view

Expected: the action item is solid white
Actual: the action item is still as faded as it was when the reload happened.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dd2506d48693bae425b7d37a8fc0fb21e0340e4

commit 6dd2506d48693bae425b7d37a8fc0fb21e0340e4
Author: dgn <dgn@chromium.org>
Date: Thu Feb 02 18:53:09 2017

[NTP Client] Reset ActionItem view properties along visibility updates.

A section's ActionItem can be altered during a swipe to dismiss, but
its state is not properly cleared when new suggestions are added at
that same time. This patch fixes that by issuing a partial update
request on significant suggestion count changes.

BUG= 687977 

Review-Url: https://codereview.chromium.org/2635993002
Cr-Commit-Position: refs/heads/master@{#447808}

[modify] https://crrev.com/6dd2506d48693bae425b7d37a8fc0fb21e0340e4/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
[modify] https://crrev.com/6dd2506d48693bae425b7d37a8fc0fb21e0340e4/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Comment 2 by dgn@chromium.org, Feb 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment