New issue
Advanced search Search tips

Issue 687976 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-03-31
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove chrome://flags#enable-pointer-events

Project Member Reported by rbyers@chromium.org, Feb 2 2017

Issue description

It still says "experimental".  Time to just remove the flag all together?
https://mobile.twitter.com/patrick_h_lauke/status/827119542023417856
 
Status: Assigned (was: Untriaged)
I will keep the flag (with a correct description) around for a while for testing.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3686bb2cc1b99f3673d210588708cbd9100272d4

commit 3686bb2cc1b99f3673d210588708cbd9100272d4
Author: mustaq <mustaq@chromium.org>
Date: Fri Feb 03 17:40:22 2017

Fixed chrome://flags#enable-pointer-events description.

BUG= 687976 

Review-Url: https://codereview.chromium.org/2678463002
Cr-Commit-Position: refs/heads/master@{#448019}

[modify] https://crrev.com/3686bb2cc1b99f3673d210588708cbd9100272d4/chrome/app/generated_resources.grd

NextAction: 2017-03-31
Will consider removing the flag at eoq.
Cc: nzolghadr@chromium.org
Labels: Hotlist-Input-Dev
Owner: eirage@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0378b3560726088bb24b5ae81bef3f94753855f0

commit 0378b3560726088bb24b5ae81bef3f94753855f0
Author: eirage <eirage@chromium.org>
Date: Thu Jun 08 14:34:08 2017

Remove chrome://flag enable-pointer-events

Remove Pointer Event flag because it was added in Chrome 55.
This feature will not be unship. It's safe to remove.

BUG= 687976 

Review-Url: https://codereview.chromium.org/2921923002
Cr-Commit-Position: refs/heads/master@{#477961}

[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/chrome/browser/about_flags.cc
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/content/child/runtime_features.cc
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/content/public/common/content_features.cc
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/third_party/WebKit/Source/core/dom/Element.idl
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/third_party/WebKit/Source/core/dom/GlobalEventHandlers.idl
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/third_party/WebKit/Source/core/events/PointerEvent.idl
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/0378b3560726088bb24b5ae81bef3f94753855f0/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83e2cb3b273b884e384be7abeef3fc72c4bd82c8

commit 83e2cb3b273b884e384be7abeef3fc72c4bd82c8
Author: Ella Ge <eirage@chromium.org>
Date: Wed Aug 02 17:40:21 2017

cleanup a line for remove PointerEvent flag

Remove a line missed when removing enable-pointer-event
flag. Related cl:

https: //codereview.chromium.org/2921923002
Bug:  687976 
Change-Id: I1d129b05fce79a565ff9a92493d2e16c2d383cf8
Reviewed-on: https://chromium-review.googlesource.com/596689
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491426}
[modify] https://crrev.com/83e2cb3b273b884e384be7abeef3fc72c4bd82c8/content/public/common/content_features.h

Sign in to add a comment