New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687973 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

When navigating from a page using MediaSession API to a page which is not, the metadata persists

Project Member Reported by zqzh...@chromium.org, Feb 2 2017

Issue description

1. Goto MediaSession test page and play some media
2. Navigate to another page not using MediaSession API and play some media

The title and artist are wrong :(
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0a34cb69bdca47cfe3dd3d1cead96446391dcbf

commit b0a34cb69bdca47cfe3dd3d1cead96446391dcbf
Author: zqzhang <zqzhang@chromium.org>
Date: Mon Feb 06 11:36:56 2017

[Media>UI] Reset media metadata when navigating away

There is a bug caused by media metadata being not properly reset when
navigating away, so that the notification title and artist stays the
same when the new page starts to play media. This CL fixes the issue.

BUG= 687973 

Review-Url: https://codereview.chromium.org/2675693004
Cr-Commit-Position: refs/heads/master@{#448231}

[modify] https://crrev.com/b0a34cb69bdca47cfe3dd3d1cead96446391dcbf/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
[modify] https://crrev.com/b0a34cb69bdca47cfe3dd3d1cead96446391dcbf/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

Labels: Merge-Request-57
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 6 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b28681089588dd01dde75af82f849a80febebea0

commit b28681089588dd01dde75af82f849a80febebea0
Author: Zhiqiang Zhang <zqzhang@google.com>
Date: Mon Feb 06 12:47:16 2017

[Media>UI] Reset media metadata when navigating away

There is a bug caused by media metadata being not properly reset when
navigating away, so that the notification title and artist stays the
same when the new page starts to play media. This CL fixes the issue.

BUG= 687973 

Review-Url: https://codereview.chromium.org/2675693004
Cr-Commit-Position: refs/heads/master@{#448231}
(cherry picked from commit b0a34cb69bdca47cfe3dd3d1cead96446391dcbf)

Review-Url: https://codereview.chromium.org/2678803002 .
Cr-Commit-Position: refs/branch-heads/2987@{#321}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/b28681089588dd01dde75af82f849a80febebea0/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
[modify] https://crrev.com/b28681089588dd01dde75af82f849a80febebea0/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

Status: Fixed (was: Started)

Sign in to add a comment