New issue
Advanced search Search tips

Issue 687960 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 641508
issue 644518
issue 644564
issue 644565
issue 645135
issue 678749
issue 683355
issue 695898



Sign in to add a comment

☂ VR: Offer menu mode and related UI in WebVR mode

Project Member Reported by cjgrant@chromium.org, Feb 2 2017

Issue description

Various VR UI components such as virtual keyboard, navigation buttons and menu mode are landing in 2D mode browsing, but not yet WebVR.

For the most part, most of these can be enabled in WebVR with a switch.

This bug tracks the switch-flipping for all supported features in WebVR, so the corresponding feature bugs can be closed when they work in 2D mode.
 
Owner: cjgrant@chromium.org
Status: Assigned (was: Available)
Blockedon: 695898

Comment 3 by girard@chromium.org, Mar 20 2017

Summary: ☂ VR: Offer menu mode and related UI in WebVR mode (was: VR: Offer menu mode and related UI in WebVR mode)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/314b385358094f67c6afaaf5dabe3cbe1955dbd4

commit 314b385358094f67c6afaaf5dabe3cbe1955dbd4
Author: cjgrant <cjgrant@chromium.org>
Date: Mon Mar 20 20:45:40 2017

Add menu mode plumbing for WebVR mode.

- Allow the UI to suppress rendering of WebVR content.
- Allow the UI to enable/disable the cursor.
- Move API-related Javascript to the API module.
- Other related cleanup.

This change does not see menu mode work yet.  crbug.com/703177  needs to
be resolved first.

BUG= 687960 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2749703007
Cr-Commit-Position: refs/heads/master@{#458175}

[modify] https://crrev.com/314b385358094f67c6afaaf5dabe3cbe1955dbd4/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/314b385358094f67c6afaaf5dabe3cbe1955dbd4/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/314b385358094f67c6afaaf5dabe3cbe1955dbd4/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/314b385358094f67c6afaaf5dabe3cbe1955dbd4/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/314b385358094f67c6afaaf5dabe3cbe1955dbd4/chrome/browser/resources/vr_shell/vr_shell_ui.js
[modify] https://crrev.com/314b385358094f67c6afaaf5dabe3cbe1955dbd4/chrome/browser/resources/vr_shell/vr_shell_ui_api.js
[modify] https://crrev.com/314b385358094f67c6afaaf5dabe3cbe1955dbd4/chrome/browser/resources/vr_shell/vr_shell_ui_scene.js

Comment 5 by tiborg@chromium.org, Mar 20 2017

Blocking: 703333

Comment 6 by tiborg@chromium.org, Mar 20 2017

Blocking: -703333

Comment 7 by tiborg@chromium.org, Mar 20 2017

Blocking: 703345

Comment 8 by tiborg@chromium.org, Mar 20 2017

Blocking: 689139
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30fc05395028eb75715e994406397463341e54da

commit 30fc05395028eb75715e994406397463341e54da
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Mar 23 22:28:15 2017

Add a progress indicator to the VR omnibox

The current UX thinking is that the URL indicator (visible transiently
on navigations), and the omnibox, are distict elements that share some
visual similarity.  Mirror the URL indicator's progress-indicating
border on the omnibox, so that there's visible loading progress in the
menu.

Even if we decide that all menu-driven navigations immediately exit the
menu, the user may still pop back into the menu during loading.

BUG= 687960 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2773533002
Cr-Commit-Position: refs/heads/master@{#459257}

[modify] https://crrev.com/30fc05395028eb75715e994406397463341e54da/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/30fc05395028eb75715e994406397463341e54da/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/30fc05395028eb75715e994406397463341e54da/chrome/browser/resources/vr_shell/vr_shell_ui.js

Blocking: -703345
Blocking: -689139
Labels: -VR-FF OS-Linux
Owner: ----
Status: Available (was: Assigned)
Labels: -OS-Linux
Labels: Pri-2
Status: Archived (was: Available)
"Menu mode" is now tracked in go/chrome-vr-backlog.

Sign in to add a comment