Issue 687921 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	gambard@chromium.org
Closed:	Feb 2017
Cc:	ios-bugs@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	3
Type:	Bug

Create a common WebPDecoderDelegate

Project Member Reported by gambard@chromium.org, Feb 2 2017

Issue description

ImageDataFetcherWrapper, its unit test and ImageDecoder share the same implementation of WebPDecoderDelegate. It should be refactored in a common code.

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e94a602b2adc854bc7f8accffef20fcf5b1f54e0

commit e94a602b2adc854bc7f8accffef20fcf5b1f54e0
Author: gambard <gambard@chromium.org>
Date: Fri Feb 17 11:05:13 2017

Add a static method to WebPDecoder to decode WebP

This CL adds a method to the WEBPDecoder to allow easier decoding.
Before each class has to implement its own delegate.

BUG= 687921 

Review-Url: https://codereview.chromium.org/2689213010
Cr-Commit-Position: refs/heads/master@{#451279}

[modify] https://crrev.com/e94a602b2adc854bc7f8accffef20fcf5b1f54e0/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.mm
[modify] https://crrev.com/e94a602b2adc854bc7f8accffef20fcf5b1f54e0/components/image_fetcher/ios/ios_image_data_fetcher_wrapper_unittest.mm
[modify] https://crrev.com/e94a602b2adc854bc7f8accffef20fcf5b1f54e0/ios/chrome/browser/suggestions/ios_image_decoder_impl.mm
[modify] https://crrev.com/e94a602b2adc854bc7f8accffef20fcf5b1f54e0/ios/web/public/image_fetcher/webp_decoder.h
[modify] https://crrev.com/e94a602b2adc854bc7f8accffef20fcf5b1f54e0/ios/web/public/image_fetcher/webp_decoder.mm

Comment 2 by gambard@chromium.org, Feb 20 2017

Status: Fixed (was: Assigned)

►

Issue 687921 link

Issue metadata

Create a common WebPDecoderDelegate

Issue description

Comment 1 by bugdroid1@chromium.org, Feb 17 2017

Comment 1 Deleted

Comment 2 by gambard@chromium.org, Feb 20 2017

Comment 2 Deleted

Sign in to add a comment