New issue
Advanced search Search tips

Issue 687904 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup non-LRU cache code.

Project Member Reported by jif@chromium.org, Feb 2 2017

Issue description

LRU is enabled for all devices, so we need to remove the non LRU code path.
 
Components: UI>Browser>Mobile>TabSwitcher
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5104459f52c44caa94a5550e51bb3d29bcd4ec01

commit 5104459f52c44caa94a5550e51bb3d29bcd4ec01
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue May 30 14:52:16 2017

[ios] Remove SnapshotCache -useLRUCache method.

The experiment is over and the LRU cache is always used, remove the
method -useLRUCache and the old code path (using a NSDictionary).

Fix improper uses of abbreviation when naming variables ("img" used
for "image" which is against the style guide).

BUG= 687904 

Change-Id: Ideab521b1c1f541e344e0ca5f398adc685a83b3d
Reviewed-on: https://chromium-review.googlesource.com/517498
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475523}
[modify] https://crrev.com/5104459f52c44caa94a5550e51bb3d29bcd4ec01/ios/chrome/browser/snapshots/snapshot_cache.mm
[modify] https://crrev.com/5104459f52c44caa94a5550e51bb3d29bcd4ec01/ios/chrome/browser/snapshots/snapshot_cache_internal.h
[modify] https://crrev.com/5104459f52c44caa94a5550e51bb3d29bcd4ec01/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm

Owner: sdefresne@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment