Issue metadata
Sign in to add a comment
|
Regression : 'Zoom' icon is not seen in omnibox after zooming in for the second instance.
Reported by
yfulgaon...@etouch.net,
Feb 2 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version : 58.0.2999.4 (Official Build) 260734633f0624551d6b79597c0dad641420911a-refs/branch-heads/2999@{#4} 64 bit OS : Mac(10.12.1, 10.11.6, 10.12) What steps will reproduce the problem? 1. Launch Chrome, open NTP and press 'Cmd +' keys to zoom in the page. (wait untill zoom bubble vanishes from omnibox) 2. Now press 'Cmd' + '0' (page zoom sets to default) and then again press 'Cmd +' keys to zoom in the page. 3. Observe the 'zoom' bubble and 'zoom' icon in omnibox. Actual : 'Zoom' icon is not seen in omnibox after zooming in for the second instance, instead only zoom bubble is seen. Expected : 'Zoom' icon should appear in omnibox after zooming in for the second instance. This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info. Good build : 57.0.2980.0 Bad build : 57.0.2981.0 Note : 1. The 'Zoom' icon appears back after hovering beside 'Bookmark' icon. 2. This is Mac specific issue and the same is working fine on Windows & Linux OS.
,
Feb 2 2017
Working as intended
,
Feb 2 2017
Oh wait, I was looking at the wrong video. My bad
,
Feb 8 2017
spqchan@ Could you please let us know is there any latest update available on this issue? Thanks!
,
Feb 8 2017
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d88656394d232e54292d28ba07659182b3e331c6 commit d88656394d232e54292d28ba07659182b3e331c6 Author: spqchan <spqchan@chromium.org> Date: Fri Feb 10 19:46:47 2017 [Mac] Fix for zoom decoration regression The decoration should update if its visibility has changed BUG= 687903 Review-Url: https://codereview.chromium.org/2688603003 Cr-Commit-Position: refs/heads/master@{#449700} [modify] https://crrev.com/d88656394d232e54292d28ba07659182b3e331c6/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
,
Feb 10 2017
,
Feb 11 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 13 2017
Please merge your change to M57 branch 2987 by 5:00 PM PT Monday (02/13) so we can pick it up for next beta release. Thank you.
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee4a11844083775b5294e0d25d45e75e095f8f65 commit ee4a11844083775b5294e0d25d45e75e095f8f65 Author: spqchan <spqchan@chromium.org> Date: Mon Feb 13 21:06:17 2017 [Mac] Fix for zoom decoration regression The decoration should update if its visibility has changed BUG= 687903 Review-Url: https://codereview.chromium.org/2688603003 Cr-Commit-Position: refs/heads/master@{#449700} (cherry picked from commit d88656394d232e54292d28ba07659182b3e331c6) Review-Url: https://codereview.chromium.org/2692973002 . Cr-Commit-Position: refs/branch-heads/2987@{#488} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/ee4a11844083775b5294e0d25d45e75e095f8f65/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
,
Feb 13 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jmukthavaram@chromium.org
, Feb 2 2017Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)