New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687894 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Parent account gets opened after removing the supervise user profile from chrome://settings page even after exit and childlock

Project Member Reported by brajkumar@chromium.org, Feb 2 2017

Issue description

Chrome Version: 57.0.2987.21
OS: Windows-10, Ubuntu 14.04 and Mac OS 10.12

What steps will reproduce the problem?
(1) Open chrome and login to account
(2) Click on manage people from RHS profile icon
(3) Click on "Add Person"
(4) Create or Import supervise user from the current account
(5) After supervised user profile is created navigate to parent account
(6) Click on Exit and childlock from RHS of avatar icon
(7) Navigate to supervise user and open chrome://settings page
(8) Remove the current supervise user profile

What is the expected result?
Parent account should not get open until the user enter the account password

What happens instead?
Parent account will open by itself after step-8 without entering any password

Bisect Information:
---------------------
Good build:57.0.2931.0
Bad build: 57.0.2933.0

Change Log URL: https://chromium.googlesource.com/chromium/src/+log/56f03f53c9dd7cd2977b6e06dd724f07187124a7..198d711e1e047b20d235c430a697f1b39a651b08
From the above change log suspecting below change

Review URL: https://codereview.chromium.org/2519953004

bauerb@ - Unable to find the authors name from the owners list, so as a reviewer assigning it to you. Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Since this is a recent regression observed on latest M-57 adding RB-Stable, so please feel free to edit if this is not the case.

Thanks!

 
Attaching screen-cast of actual and expected behavior for reference.
Actual.mp4
1.6 MB View Download
Expected.mp4
4.3 MB View Download
Components: UI>Browser>Profiles
palar, can you take a look?
working on it
Can't signin with local build of chromium, google api keys missing or something
like that.

There should't be any difference with named patch, both pre and post states
should end up with call of CreateProfileAsync supplied with locked profile path
and the same other params.

I'd expect the same behavior on Mac but there https://codereview.chromium.org/2516613002/
which can explain the difference (latest stable ver.56.0.2924.87 build has the same logic on mac), and on other platforms browser will be closed, 
and on browser launch user manager window will be opened due
CreatePrimaryProfile() logic.

There the patch which can resolve this issue, can't check it myself through:

diff --git a/chrome/browser/ui/webui/profile_helper.cc b/chrome/browser/ui/webui/profile_helper.cc
index c5ce2de..2f4622f 100644
--- a/chrome/browser/ui/webui/profile_helper.cc
+++ b/chrome/browser/ui/webui/profile_helper.cc
@@ -43,7 +43,8 @@ void DeleteProfileCallback(std::unique_ptr<ScopedKeepAlive> keep_alive,
 }  // namespace

 void OpenNewWindowForProfile(Profile* profile) {
-  if (signin::IsForceSigninEnabled()) {
+  if (signin::IsForceSigninEnabled() ||
+      profiles::IsProfileLocked(profile->GetPath())) {
     if (!UserManager::IsShowing()) {
       UserManager::Show(base::FilePath(), profiles::USER_MANAGER_NO_TUTORIAL,
                         profiles::USER_MANAGER_SELECT_PROFILE_NO_ACTION);



A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Ok, fine. I don't really need any external services to lock profile.
Checked solution myself and it works.

Here we go: https://codereview.chromium.org/2681333002
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33e953c922b7dcfa88418ae62d098d6d3e869535

commit 33e953c922b7dcfa88418ae62d098d6d3e869535
Author: palar <palar@yandex-team.ru>
Date: Fri Feb 10 12:08:53 2017

Fixed an issue with fallback on locked profile upon profile deletion.

BUG= 687894 

R=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2681333002
Cr-Commit-Position: refs/heads/master@{#449594}

[modify] https://crrev.com/33e953c922b7dcfa88418ae62d098d6d3e869535/chrome/browser/ui/webui/profile_helper.cc

Verified this issue on Mac OS 10.12, Windows-10 and Ubuntu 14.04 using chrome latest canary M58-58.0.3012.0, observed the parent account is not getting opened while removing the supervised user as expected.

Note: After removing the supervised user account from chrome://settings it opens a new sign-in manager to login to account instead the parent account log-in manager where we can enter the password to log-in. This issue is observed on Mac and Windows, it's working fine on Ubuntu 14.04.

palar@ Could you please take a look in to it?

Thanks!
687894.mp4
1.4 MB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58084dd8f1d79ce115ee976daa4f1d6b8d51481b

commit 58084dd8f1d79ce115ee976daa4f1d6b8d51481b
Author: palar <palar@yandex-team.ru>
Date: Tue Feb 14 17:05:13 2017

Show reauth dialog instead of signin dialog when trying to open
a locked profile.

BUG= 687894 
R=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2692863004
Cr-Commit-Position: refs/heads/master@{#450386}

[modify] https://crrev.com/58084dd8f1d79ce115ee976daa4f1d6b8d51481b/chrome/browser/ui/webui/profile_helper.cc

A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
Cc: ranjitkan@chromium.org
@ palar: Can you please provide an update as requested in comment#8 

Thanks.!
Not sure what exactly expected of me.

Changeset from comment#9 should fix the issue from comment#8.
Thank you palar@. Could you please request a merge to M57 by adding "Merge-Request-57" label as this bug is reported as M57 Stable blocker?

ranjitkan@, please verify issue from comment #8 on Canary version 58.0.3019.0 (Yesterday's canary). And update the bug please. Thank you.
Labels: TE-Verified-M58 TE-Verified-58.0.3019.0
Verified this issue on chrome latest M58-58.0.3019.0 by following steps mentioned in the original comment. Observed the the locked parent account is not getting opened until the user enters the password and comment #8 issue is not observed after the latest fix of comment #9. Hence adding TE-Verified label for M-58.

Thanks!

Thank you  brajkumar@.

palar@, please request a merge to M57 by adding "Merge-Request-57" label. Thank you.

URGENT - PTAL ASAP.

We're getting VERY close to M57 Stable promotion. And 
this issue is marked as M57 stable release blocker. Pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion).

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.

Comment 17 Deleted

bauerb@, please request a merge to M57. Do not know how to do this request, probably have not rights for such actions. Thank you.
Labels: Merge-Request-57
Project Member

Comment 20 by sheriffbot@chromium.org, Feb 22 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 22 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e65faf7760fd3172db784e175f163cd954c13ec

commit 2e65faf7760fd3172db784e175f163cd954c13ec
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Wed Feb 22 11:46:19 2017

Fixed an issue with fallback on locked profile upon profile deletion.

BUG= 687894 

R=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2681333002
Cr-Commit-Position: refs/heads/master@{#449594}
(cherry picked from commit 33e953c922b7dcfa88418ae62d098d6d3e869535)

Review-Url: https://codereview.chromium.org/2711743002 .
Cr-Commit-Position: refs/branch-heads/2987@{#639}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/2e65faf7760fd3172db784e175f163cd954c13ec/chrome/browser/ui/webui/profile_helper.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dd0d42a2ea5eb0d180e76c2b75f6fae97809d98

commit 0dd0d42a2ea5eb0d180e76c2b75f6fae97809d98
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Wed Feb 22 11:57:18 2017

Show reauth dialog instead of signin dialog when trying to open a locked profile.

BUG= 687894 
R=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2692863004
Cr-Commit-Position: refs/heads/master@{#450386}
(cherry picked from commit 58084dd8f1d79ce115ee976daa4f1d6b8d51481b)

Review-Url: https://codereview.chromium.org/2710763004 .
Cr-Commit-Position: refs/branch-heads/2987@{#640}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/0dd0d42a2ea5eb0d180e76c2b75f6fae97809d98/chrome/browser/ui/webui/profile_helper.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-57.0.2987.88 TE-Verified-M57
Verified this issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12 using chrome latest M57 #57.0.2987.88 and observed the fix is working as expected as per comment #21 and #22. Hence adding TE-Verified label for M-57.

Thanks!

Sign in to add a comment