New issue
Advanced search Search tips

Issue 687890 link

Starred by 2 users
Status: Fixed
Owner:
ehmaldonado@chromium.org
Closed: Jan 2018
Cc:
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Re-add webrtc_perf_tests to our trybots with DCHECKs enabled

Project Member Reported by kjellander@chromium.org, Feb 2 2017 
The test was removed since it had become a bottle-neck for our tryserver. We've been running with that for a while and at least twice there have been issues surfacing that would have been caught if we've kept them.

I suggest we bring them back to the desktop (to begin with) and also enable DCHECKS on the trybots (but keep it disabled for the actual perf bots).

Summary of changes:
* Revert https://codereview.chromium.org/2031673003 but only for desktop, not Android.
* Update MB with dcheck_always_on=true for the {win,mac,linux}_baremetal trybots.

I plan to drive cutting down the runtime of the longest running tests with the work done in https://bugs.chromium.org/p/webrtc/issues/detail?id=7101
After that, we can probably add it for Android as well.

Comment 1 by kjellander@chromium.org, Feb 21 2017

Status: Started (was: Assigned)
https://bugs.chromium.org/p/webrtc/issues/detail?id=7101 is now completed. 
Now https://chromium-review.googlesource.com/c/435806/ just needs to be updated and then this can land.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/df9fc3a35fda9c6f1c4c1fec701817c2113e3f59

commit df9fc3a35fda9c6f1c4c1fec701817c2113e3f59
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Wed Feb 22 14:53:13 2017

WebRTC: Re-add webrtc_perf_tests to the baremetal and android trybots.

BUG= chromium:687890 

Change-Id: Ie190a6a85a6e34573e68813c4ec8922d5b61778b
Reviewed-on: https://chromium-review.googlesource.com/435806
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/df9fc3a35fda9c6f1c4c1fec701817c2113e3f59/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/df9fc3a35fda9c6f1c4c1fec701817c2113e3f59/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json
[modify] https://crrev.com/df9fc3a35fda9c6f1c4c1fec701817c2113e3f59/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/df9fc3a35fda9c6f1c4c1fec701817c2113e3f59/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/df9fc3a35fda9c6f1c4c1fec701817c2113e3f59/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json
[modify] https://crrev.com/df9fc3a35fda9c6f1c4c1fec701817c2113e3f59/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json
[modify] https://crrev.com/df9fc3a35fda9c6f1c4c1fec701817c2113e3f59/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e0898d52c22c72d76c867d349200268f2712883b

commit e0898d52c22c72d76c867d349200268f2712883b
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Wed Feb 22 17:41:05 2017

Revert "WebRTC: Re-add webrtc_perf_tests to the baremetal and android trybots."

This reverts commit df9fc3a35fda9c6f1c4c1fec701817c2113e3f59.

Reason for revert: 
Android and mac trybots are failing.
https://uberchromegw.corp.google.com/i/tryserver.webrtc/builders/mac_baremetal/builds/19078
https://uberchromegw.corp.google.com/i/tryserver.webrtc/builders/android_dbg/builds/21655

Original change's description:
> WebRTC: Re-add webrtc_perf_tests to the baremetal and android trybots.
> 
> BUG= chromium:687890 
> 
> Change-Id: Ie190a6a85a6e34573e68813c4ec8922d5b61778b
> Reviewed-on: https://chromium-review.googlesource.com/435806
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> 

TBR=kjellander@chromium.org,ehmaldonado@chromium.org,chromium-reviews@chromium.org,ehmaldonado@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:687890 

Change-Id: I2d27dae16f1115aa3f4220f52dacf5229a95e601
Reviewed-on: https://chromium-review.googlesource.com/445781
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e0898d52c22c72d76c867d349200268f2712883b

commit e0898d52c22c72d76c867d349200268f2712883b
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Wed Feb 22 17:41:05 2017

Revert "WebRTC: Re-add webrtc_perf_tests to the baremetal and android trybots."

This reverts commit df9fc3a35fda9c6f1c4c1fec701817c2113e3f59.

Reason for revert: 
Android and mac trybots are failing.
https://uberchromegw.corp.google.com/i/tryserver.webrtc/builders/mac_baremetal/builds/19078
https://uberchromegw.corp.google.com/i/tryserver.webrtc/builders/android_dbg/builds/21655

Original change's description:
> WebRTC: Re-add webrtc_perf_tests to the baremetal and android trybots.
> 
> BUG= chromium:687890 
> 
> Change-Id: Ie190a6a85a6e34573e68813c4ec8922d5b61778b
> Reviewed-on: https://chromium-review.googlesource.com/435806
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> 

TBR=kjellander@chromium.org,ehmaldonado@chromium.org,chromium-reviews@chromium.org,ehmaldonado@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:687890 

Change-Id: I2d27dae16f1115aa3f4220f52dacf5229a95e601
Reviewed-on: https://chromium-review.googlesource.com/445781
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json
[modify] https://crrev.com/e0898d52c22c72d76c867d349200268f2712883b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json

Comment 5 by kjellander@chromium.org, Mar 8 2017 

Can we pick up this again?
As discussed in https://bugs.chromium.org/p/webrtc/issues/detail?id=7153; let's add this test on the platforms that works first (Linux, Windows).

Then we'll make another CL for Android, since the failure in https://uberchromegw.corp.google.com/i/tryserver.webrtc/builders/android_dbg/builds/21655 seems to have been an infra error only.

Then finally we can approach Mac. Possibly we might want to add a mac_experimental trybot that we can use for trying things out for that test, since Ilya wasn't able to reproduce the crash we were seeing on the bot.

Comment 7 by kjellander@chromium.org, Mar 21 2017 

Can you make a CL for Android for this one?
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/e55f91ce4781dcfc4b16bf628568d3b057222020

commit e55f91ce4781dcfc4b16bf628568d3b057222020
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Wed Mar 22 12:40:14 2017

MB: Add webrtc_perf_tests to gn_isolate_map.pyl

BUG= chromium:687890 
NOTRY=True

Review-Url: https://codereview.webrtc.org/2766513006
Cr-Commit-Position: refs/heads/master@{#17340}

[modify] https://crrev.com/e55f91ce4781dcfc4b16bf628568d3b057222020/tools-webrtc/mb/gn_isolate_map.pyl

Comment 10 by kjellander@chromium.org, Mar 27 2017

Labels: OS-Android
Summary: Re-add webrtc_perf_tests to our trybots with DCHECKs enabled (was: Re-add webrtc_perf_tests to our baremetal trybots with DCHECKs enabled)
Rephrasing to include Android as well, since that's already been added.

Comment 11 by kjellander@chromium.org, Mar 27 2017 

 Issue 645349  has been merged into this issue.

Comment 12 by kjellander@chromium.org, Sep 21 2017 

Isn't this done?

Comment 13 by phoglund@chromium.org, Jan 19 2018

Status: Fixed (was: Started)
webrtc_perf_tests are running at least on the win baremetal bot, so I think this is fixed.
►

Sign in to add a comment