Add ability to filter download suggestions by age |
||||||
Issue descriptionStale download suggestions might be of lower value (similar to bookmarks). We should add a finch-controllable threshold that allows us to not show download items older than N days. What's considered age? Ideally, we would take two signals: creation data and last-visited date. We're discussing with the downloads team about the feasibility of adding a "last-visited" attribute to the DownloadItem. However, until then we can already add the filter by creation time and later add an option to take the max(creation date, last-visited date) to compute the article age.
,
Feb 2 2017
,
Feb 2 2017
Which default value we want? Something like 10 years (to ignore the filtering by age) or 6 weeks?
,
Feb 2 2017
I'd say 6 weeks is essentially infinite already for practical uses ;-)
,
Feb 2 2017
so 6 weeks as default?
,
Feb 2 2017
Yes, sure! I am working on the CL right now.
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dc672d93b3705ea017b2f538daa73408d970f7a commit 6dc672d93b3705ea017b2f538daa73408d970f7a Author: vitaliii <vitaliii@chromium.org> Date: Tue Feb 07 11:08:24 2017 [NTP::Downloads] Do not show old downloads. Add a variation parameter to choose what is considered "old" (by default 6 weeks) and not show downloads (both assets and offline pages) older than that. Reasoning: the section is meant for quick access, so if the user happens to have only old downloads, there is no point to show them. BUG= 687888 Review-Url: https://codereview.chromium.org/2673633002 Cr-Commit-Position: refs/heads/master@{#448596} [modify] https://crrev.com/6dc672d93b3705ea017b2f538daa73408d970f7a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/6dc672d93b3705ea017b2f538daa73408d970f7a/chrome/browser/ntp_snippets/download_suggestions_provider.cc [modify] https://crrev.com/6dc672d93b3705ea017b2f538daa73408d970f7a/chrome/browser/ntp_snippets/download_suggestions_provider.h [modify] https://crrev.com/6dc672d93b3705ea017b2f538daa73408d970f7a/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
,
Feb 7 2017
I also consider offline page last_access_time as a signal in CL https://codereview.chromium.org/2683553003.
,
Feb 7 2017
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c02cd260268b3d459a188308a1f70a5bd6a048f7 commit c02cd260268b3d459a188308a1f70a5bd6a048f7 Author: vitaliii <vitaliii@chromium.org> Date: Tue Feb 07 13:57:47 2017 [NTP::Downloads] Consider recently visited offline pages not outdated. Take into account last_access_time of offline page downloads. Consider offline page downloads which were visited recently (not more than threshold before) not outdated and show them. Reason: if you visit an old download, it is probably interesting to you, even though old. BUG= 687888 Review-Url: https://codereview.chromium.org/2683553003 Cr-Commit-Position: refs/heads/master@{#448613} [modify] https://crrev.com/c02cd260268b3d459a188308a1f70a5bd6a048f7/chrome/browser/ntp_snippets/download_suggestions_provider.cc [modify] https://crrev.com/c02cd260268b3d459a188308a1f70a5bd6a048f7/chrome/browser/ntp_snippets/download_suggestions_provider.h [modify] https://crrev.com/c02cd260268b3d459a188308a1f70a5bd6a048f7/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
,
Feb 8 2017
When the last_access_time is collected for asset downloads, we will get back to this.
,
Feb 8 2017
I created a bug for using last_access_time of asset downloads. See issue 689965 .
,
Mar 2 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vitaliii@chromium.org
, Feb 2 2017Owner: vitaliii@chromium.org
Status: Assigned (was: Untriaged)