New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687855 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 683021
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Thumbnails on NTP does not get loaded properly after killing NTP.

Reported by rk...@etouch.net, Feb 2 2017

Issue description

Chrome Version: 58.0.3000.0 Revision ed1f2fac6209f8d2e0db3f7dcff38d1e69f5db26-refs/heads/master@{#447669}
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
(1) Launch chrome, open NTP and kill NTP by chrome://kill
(2) Reload that NTP and observe thumbnails.

Actual: Thumbnails on NTP does not get loaded properly after killing NTP.

Expected: Thumbnails should seen properly after killing NTP. 

This is a regression issue, broken in 'M-57', will soon update the other info:

Good Build: 57.0.2983.0
Bad Build: 57.0.2984.0
 
Actual_Thumbnail.mp4
331 KB View Download
Expected_Thumbnail.mp4
233 KB View Download
Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: tibell@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 57.0.2982.0,  Revision Range - 443804
Bad build  : 57.0.2984.0,  Revision Range - 443964

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/dc7d397153bcbccbc21e12f2ea3568f594699220..e3df8cd8ac45539711b1f0b6a00420f87d09d279

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/e3df8cd8ac45539711b1f0b6a00420f87d09d279

Review-Url: https://codereview.chromium.org/2086223002

tibell@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Cc: treib@chromium.org
treib@, this is not related to "remote NTP" -> "local NTP" transition?
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 4 by treib@chromium.org, Feb 2 2017

Labels: -M-58 M-57
Re #2, nope, nothing user-visible has happened there yet. This in indeed tibell's Mojo change.

We already had a bug for this, let me try to find it...

Comment 5 by treib@chromium.org, Feb 2 2017

Okay, so we don't have an exact duplicate, but we have the similar  bug 683021 , which I assumed had the same root cause,  bug 683794 . However, that one has been fixed and merged already, so if this one still occurs, it's a different issue.

Comment 6 by treib@chromium.org, Feb 2 2017

I can reproduce this, so it's indeed a separate problem. In addition to the tiles, it also affects the search box, which doesn't work after the reload.

All the window.chrome.embeddedSearch APIs do exist after the reload, but something in the binding seems to be broken.

Comment 7 by treib@chromium.org, Feb 2 2017

Turns out  bug 683021  isn't actually fixed, so it's very likely the same problem after all.

Comment 8 by fi...@chromium.org, Feb 3 2017

Labels: zine-triaged
Mergedinto: 683021
Status: Duplicate (was: Assigned)
This is actually the same as  bug 683021 , which I thought I had fixed. I now have a follow-up fix for  bug 683021 , so I'm merging this as duped.

Sign in to add a comment