New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687848 link

Starred by 1 user
Status: Verified
Owner:
wangxianzhu@chromium.org
Closed: Feb 2017
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: In chrome://extensions, on closing Print overlay, weird UI is seen.

Reported by lpa...@etouch.net, Feb 2 2017 
Chrome Version: 58.0.2999.5 (Official Build) 6c86d19d495b8ab045d74b3c19addca0fc1ffd48-refs/branch-heads/2999@{#5} (32/64-bit)
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

What steps will reproduce the problem?
1) Launch chrome, go to chrome://extensions and check 'Developer mode' checkbox.
2) Click on 'Pack extension' button and then in Pack extension overlay click on 'Pack extension' button.
3) Now in overlay select some text, give Print command and then click on 'More settings' option.
4) Under 'Options', check and then uncheck 'Background graphics' checkbox, close the Print overlay and observe.

Weird and distorted UI is seen on closing Print overlay.

Weird and distorted UI should not be seen on closing Print overlay.

This is a Regression issue broken in M-58, will soon update other info
Manual bisect:
Good build: 58.0.2991.0
Bad build: 58.0.2992.0
extensions_actual.mp4
1.0 MB View Download
extension_expected.mp4
849 KB View Download

Comment 1 by hdodda@chromium.org, Feb 2 2017

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.2991.0 (revision : 445609)
Bad build: 58.0.2992.0 (revision : 445908)

You are probably looking for a change made after 445777 (known good), but no later than 445778 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/cd207440f74f112ed24d1e72b63fddbca063dcc9..9686be68e53348bab6f4ce846bf07d494f1575a0

From the CL above, assigning the issue to the concern owner 

@wangxianzhu - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2647393002

Note : Adding RB- Stable as this is an recent regression , please feel free to edit/remove this.

Thanks!

Comment 2 by wangxianzhu@chromium.org, Feb 3 2017 

Reduced test case:
<iframe style="width: 100%; height: 800px" srcdoc="
  <div style='position: fixed; border: 20px solid black; right: 0'>
    <div>Select some text and print. Border should not disappear.</div>
  </div>">
</iframe>
print.html
229 bytes View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/604a36b20d9ffe65380031f3f708d859d81f71be

commit 604a36b20d9ffe65380031f3f708d859d81f71be
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Sun Feb 05 10:02:54 2017

Fix paint invalidation issue on exiting printing

This was caused by https://codereview.chromium.org/2583733003. I forgot
to remove the !slimmingPaintInvalidationEnabled() condition.

I failed to create an automatic test. Even the manual test can't
reproduce the bug if printing is started by script 'print()'.

BUG= 687848 

Review-Url: https://codereview.chromium.org/2675763006
Cr-Commit-Position: refs/heads/master@{#448183}

[add] https://crrev.com/604a36b20d9ffe65380031f3f708d859d81f71be/third_party/WebKit/ManualTests/print-iframe-containing-fixed.html
[modify] https://crrev.com/604a36b20d9ffe65380031f3f708d859d81f71be/third_party/WebKit/Source/core/frame/LocalFrame.cpp

Comment 4 by sureshkumari@chromium.org, Feb 7 2017

Labels: TE-verified-58.0.3004.3 TE-Verified-M58
Tested the issue on windows 7, Mac 10.12.2, Linux Ubuntu 14.04 using chrome dev version-58.0.3004.3 with the steps mentioned in comment #0 and issue is fixed. 
Not Observed Weird and distorted UI on closing Print overlay.

Please find the attached screen cast for the same.

Adding TE-Verified labels.

Thanks..
687848.mp4
862 KB View Download

Comment 5 by wangxianzhu@chromium.org, Feb 7 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment