New issue
Advanced search Search tips

Issue 687843 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocking:
issue 687462



Sign in to add a comment

Understand real world usage of -webkit-user-modify

Project Member Reported by xiaoche...@chromium.org, Feb 2 2017

Issue description

The current usage of -webkit-user-modify is still too high for removal, so we should have a better understanding of the usage

In addition, the removal of value 'read-write-plaintext-only' may result in functionality loss. We should understand if the functionality loss is acceptable.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d71997cab809617592987ba993d0261cdde19a9a

commit d71997cab809617592987ba993d0261cdde19a9a
Author: xiaochengh <xiaochengh@chromium.org>
Date: Thu Feb 02 11:17:18 2017

Add usage counter for each value of webkit-user-modify

This patch adds usage counter for each value of webkit-user-modify so
that we can have a better understanding of its current usage, and the
functionality loss about 'read-write-plaintext-only' if the property
is removed.

BUG=687843

Review-Url: https://codereview.chromium.org/2668423004
Cr-Commit-Position: refs/heads/master@{#447741}

[modify] https://crrev.com/d71997cab809617592987ba993d0261cdde19a9a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/d71997cab809617592987ba993d0261cdde19a9a/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/d71997cab809617592987ba993d0261cdde19a9a/tools/metrics/histograms/histograms.xml

Summary: Understand real world usage of -webkit-user-modify (was: Instrument usage counter for each value of -webkit-user-modify)
Cc: jfernan...@igalia.com
Labels: Merge-Request-57
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 4 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge your change to M57 branch 2987 before 5:00 PM PT, Monday (02/06/) so we can pick it up for next Beta release. Thank you.
I'm waiting for the decision on  issue 686254 .

As rtoy@ doesn't want to mess up the counter ids the merging of r447655, I don't want to mess up the counters, either.
Project Member

Comment 8 by sheriffbot@chromium.org, Feb 7 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
If possible, please merge your change to M57 branch 2987 before 5:00 PM PT today, Tuesday (02/07/17) so we can pick it up for tomorrow's Beta release. Thank you.
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 8 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d212f25aec682c8d31ac3e09c8767e69f4718bdb

commit d212f25aec682c8d31ac3e09c8767e69f4718bdb
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Feb 08 00:32:42 2017

Add usage counter for each value of webkit-user-modify

This patch adds usage counter for each value of webkit-user-modify so
that we can have a better understanding of its current usage, and the
functionality loss about 'read-write-plaintext-only' if the property
is removed.

BUG=687843

Review-Url: https://codereview.chromium.org/2668423004
Cr-Commit-Position: refs/heads/master@{#447741}
(cherry picked from commit d71997cab809617592987ba993d0261cdde19a9a)

Review-Url: https://codereview.chromium.org/2680923004 .
Cr-Commit-Position: refs/branch-heads/2987@{#373}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/d212f25aec682c8d31ac3e09c8767e69f4718bdb/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/d212f25aec682c8d31ac3e09c8767e69f4718bdb/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/d212f25aec682c8d31ac3e09c8767e69f4718bdb/tools/metrics/histograms/histograms.xml

Labels: Type-Task
NextAction: 2017-05-15
It seems that a lot of usage of -webkit-user-modify is applied to <input> or applied simultaneously with contenteditable.

We should add a usage counter for the "valid" usage by M60.
The NextAction date has arrived: 2017-05-15
NextAction: 2017-05-22
Thought I have time this week to work on this, but it doesn't proceed as so...
The NextAction date has arrived: 2017-05-22
Labels: M-61
NextAction: ----
Postpone to M61...
Labels: Pri-3
Owner: ----
Status: Available (was: Assigned)
Unassign myself as I don't have any plan to work on it.
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed9d8ec7a1e9bbb5e92c569a37f04d16c185a66a

commit ed9d8ec7a1e9bbb5e92c569a37f04d16c185a66a
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Nov 15 05:07:17 2018

Editing: Introduce two UseCounters for -webkit-user-modify and contenteditable.

* kWebKitUserModifyEffective
 It counts if contenteditable content attribute value and
 -webkit-user-modify property value are mismatched.

* kPlaintTextEditingEffective
 It counts if -webkit-user-modify:read-write-plaintext-only is effective
 or a user interact with an element with contenteditable=plaintext-only.

The counters are triggered only in Element::IsFocusable().
 - Checking all elements costs too much.
 - If a user interacts with an element, IsFocusable() must be called.
  It's ok to ignore elements without user interaction. The behavior of
  such elements isn't important for web-site compatibility.

Bug: 687843
Change-Id: Idb7a9280e1f63c4ecdca0c4ce3298c3c9be715da
Reviewed-on: https://chromium-review.googlesource.com/c/1335069
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608262}
[modify] https://crrev.com/ed9d8ec7a1e9bbb5e92c569a37f04d16c185a66a/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/ed9d8ec7a1e9bbb5e92c569a37f04d16c185a66a/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/ed9d8ec7a1e9bbb5e92c569a37f04d16c185a66a/tools/metrics/histograms/enums.xml

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/716ed445fba9f2b672b3bb6ca5a11b0898ed7b68

commit 716ed445fba9f2b672b3bb6ca5a11b0898ed7b68
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Nov 19 04:16:20 2018

Add UseCounters for effective usage of each of -webkit-user-modify values.

This is a follow-up CL of http://crrev.com/c/1335069.

Bug: 687843
Change-Id: I873dba8174a99c031e34f3e1f32672c6d275aea4
Reviewed-on: https://chromium-review.googlesource.com/c/1337143
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609177}
[modify] https://crrev.com/716ed445fba9f2b672b3bb6ca5a11b0898ed7b68/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/716ed445fba9f2b672b3bb6ca5a11b0898ed7b68/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/716ed445fba9f2b672b3bb6ca5a11b0898ed7b68/tools/metrics/histograms/enums.xml

Sign in to add a comment