New issue
Advanced search Search tips

Issue 687835 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

AXMenuItem parent is computed wrongly when viewed in sidebar pane

Project Member Reported by aboxhall@chromium.org, Feb 2 2017

Issue description

<option> appears to have no parent, as per attached image.
 
option.png
57.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbc08d987df8d944144250b50c6cffc044d517c1

commit dbc08d987df8d944144250b50c6cffc044d517c1
Author: aboxhall <aboxhall@chromium.org>
Date: Sun Feb 19 23:33:04 2017

Correctly compute parent of AXMenuListOption

BUG= 687835 

Review-Url: https://codereview.chromium.org/2670023002
Cr-Commit-Position: refs/heads/master@{#451530}

[modify] https://crrev.com/dbc08d987df8d944144250b50c6cffc044d517c1/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/dbc08d987df8d944144250b50c6cffc044d517c1/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes.html
[modify] https://crrev.com/dbc08d987df8d944144250b50c6cffc044d517c1/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/dbc08d987df8d944144250b50c6cffc044d517c1/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/dbc08d987df8d944144250b50c6cffc044d517c1/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/dbc08d987df8d944144250b50c6cffc044d517c1/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/dbc08d987df8d944144250b50c6cffc044d517c1/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/dbc08d987df8d944144250b50c6cffc044d517c1/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dd7ebcfe2458163d1faa4d0de517affec380d90

commit 8dd7ebcfe2458163d1faa4d0de517affec380d90
Author: amineer <amineer@chromium.org>
Date: Wed Feb 22 01:14:27 2017

Revert of Correctly compute parent of AXMenuListOption (patchset #8 id:160001 of https://codereview.chromium.org/2670023002/ )

Reason for revert:
Causing crashes

BUG= 687835 ,694349

Original issue's description:
> Correctly compute parent of AXMenuListOption
>
> BUG= 687835 
>
> Review-Url: https://codereview.chromium.org/2670023002
> Cr-Commit-Position: refs/heads/master@{#451530}
> Committed: https://chromium.googlesource.com/chromium/src/+/dbc08d987df8d944144250b50c6cffc044d517c1

TBR=dmazzoni@chromium.org,aboxhall@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 687835 

Review-Url: https://codereview.chromium.org/2713453002
Cr-Commit-Position: refs/heads/master@{#451865}

[modify] https://crrev.com/8dd7ebcfe2458163d1faa4d0de517affec380d90/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/8dd7ebcfe2458163d1faa4d0de517affec380d90/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes.html
[modify] https://crrev.com/8dd7ebcfe2458163d1faa4d0de517affec380d90/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/8dd7ebcfe2458163d1faa4d0de517affec380d90/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/8dd7ebcfe2458163d1faa4d0de517affec380d90/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/8dd7ebcfe2458163d1faa4d0de517affec380d90/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/8dd7ebcfe2458163d1faa4d0de517affec380d90/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/8dd7ebcfe2458163d1faa4d0de517affec380d90/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2017

Labels: merge-merged-3018
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd0fb2cede129fbf1fec11f28ceeca43339ab50c

commit cd0fb2cede129fbf1fec11f28ceeca43339ab50c
Author: dimu <dimu@google.com>
Date: Wed Feb 22 01:40:41 2017

Revert of Correctly compute parent of AXMenuListOption (patchset #8 id:160001 of https://codereview.chromium.org/2670023002/ )

Reason for revert:
Causing crashes

BUG= 687835 ,694349
NOTRY=true
NOPRESUBMIT=true

Original issue's description:
> Correctly compute parent of AXMenuListOption
>
> BUG= 687835 
>
> Review-Url: https://codereview.chromium.org/2670023002
> Cr-Commit-Position: refs/heads/master@{#451530}
> Committed: https://chromium.googlesource.com/chromium/src/+/dbc08d987df8d944144250b50c6cffc044d517c1

TBR=dmazzoni@chromium.org,aboxhall@chromium.org
BUG= 687835 

Review-Url: https://codereview.chromium.org/2713453002
Cr-Commit-Position: refs/heads/master@{#451865}
(cherry picked from commit 8dd7ebcfe2458163d1faa4d0de517affec380d90)

Review-Url: https://codereview.chromium.org/2713573002 .
Cr-Commit-Position: refs/branch-heads/3018@{#4}
Cr-Branched-From: 5e7216844858ad1d08a70ac7aeef88547db2be7f-refs/heads/master@{#451537}

[modify] https://crrev.com/cd0fb2cede129fbf1fec11f28ceeca43339ab50c/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/cd0fb2cede129fbf1fec11f28ceeca43339ab50c/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes.html
[modify] https://crrev.com/cd0fb2cede129fbf1fec11f28ceeca43339ab50c/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/cd0fb2cede129fbf1fec11f28ceeca43339ab50c/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/cd0fb2cede129fbf1fec11f28ceeca43339ab50c/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/cd0fb2cede129fbf1fec11f28ceeca43339ab50c/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/cd0fb2cede129fbf1fec11f28ceeca43339ab50c/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/cd0fb2cede129fbf1fec11f28ceeca43339ab50c/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h

Labels: NewComponent-Accessibility-DevTools NewComponent-Accessibility
Components: Platform>Apps>DevTools>Accessibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-devtools -newcomponent-accessibility
Labels: a11y-secondary
Status: Fixed (was: Untriaged)

Sign in to add a comment