New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687817 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove non-MD code paths from TrayItemMore

Project Member Reported by tdander...@chromium.org, Feb 2 2017

Issue description

Remove non-MD code paths from TrayItemMore
 
Labels: Hotlist-CodeHealth
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/469c3b662e9bb4bfc28853a166420458079cf19d

commit 469c3b662e9bb4bfc28853a166420458079cf19d
Author: mohsen <mohsen@chromium.org>
Date: Wed Feb 22 08:04:57 2017

Modify TrayItemMore to use enabled status

With this patch, if a TrayItemMore object is set to be disabled, it will
not show the more arrow and ripple animations. Therefore, |show_more_|
field is not needed anymore and is removed.

Also, non-MD code path is removed from TrayItemMore.

BUG= 687689 , 687817 

Review-Url: https://codereview.chromium.org/2699443004
Cr-Commit-Position: refs/heads/master@{#451917}

[modify] https://crrev.com/469c3b662e9bb4bfc28853a166420458079cf19d/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/469c3b662e9bb4bfc28853a166420458079cf19d/ash/common/system/chromeos/cast/tray_cast.cc
[modify] https://crrev.com/469c3b662e9bb4bfc28853a166420458079cf19d/ash/common/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/469c3b662e9bb4bfc28853a166420458079cf19d/ash/common/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/469c3b662e9bb4bfc28853a166420458079cf19d/ash/common/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/469c3b662e9bb4bfc28853a166420458079cf19d/ash/common/system/tray/tray_item_more.cc
[modify] https://crrev.com/469c3b662e9bb4bfc28853a166420458079cf19d/ash/common/system/tray/tray_item_more.h
[modify] https://crrev.com/469c3b662e9bb4bfc28853a166420458079cf19d/ash/common/system/tray_accessibility.cc

Owner: moh...@chromium.org
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment