New issue
Advanced search Search tips

Issue 687816 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove non-MD code paths from TrayBrightness

Project Member Reported by tdander...@chromium.org, Feb 2 2017

Issue description

Remove non-MD code paths from TrayBrightness
 
Labels: Hotlist-CodeHealth
Labels: -M-58 M-59

Comment 3 by est...@chromium.org, Mar 22 2017

Owner: est...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36cfbe932ed734d1935b8eeb9273aff1b80c598c

commit 36cfbe932ed734d1935b8eeb9273aff1b80c598c
Author: estade <estade@chromium.org>
Date: Mon Mar 27 18:33:02 2017

Remove some pre-md code and assets.

BUG= 687816 , 686234 , 686335 

Review-Url: https://codereview.chromium.org/2770953003
Cr-Commit-Position: refs/heads/master@{#459837}

[modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/BUILD.gn
[modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/power/power_status.cc
[modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/power/power_status.h
[modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/power/power_status_unittest.cc
[modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/session/tray_session_length_limit.cc
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/common/system/chromeos/settings/tray_settings.cc
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/common/system/chromeos/settings/tray_settings.h
[modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/resources/ash_resources.grd
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/notification/notification_session_length_timer.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_brightness.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_power_small_all.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_power_small_all_dark.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_power_small_all_dark_fluctuating.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_power_small_all_fluctuating.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_settings.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/notification/notification_session_length_timer.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_brightness.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_power_small_all.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_power_small_all_dark.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_power_small_all_dark_fluctuating.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_power_small_all_fluctuating.png
[delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_settings.png

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd95e0083676d5e1b82a3bad0c2ccef61b557230

commit cd95e0083676d5e1b82a3bad0c2ccef61b557230
Author: jwd <jwd@chromium.org>
Date: Mon Mar 27 21:30:57 2017

Revert of Remove some pre-md code and assets. (patchset #3 id:40001 of https://codereview.chromium.org/2770953003/ )

Reason for revert:
Causing failures on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

BUG= 705678 

Original issue's description:
> Remove some pre-md code and assets.
>
> BUG= 687816 , 686234 , 686335 
>
> Review-Url: https://codereview.chromium.org/2770953003
> Cr-Commit-Position: refs/heads/master@{#459837}
> Committed: https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273aff1b80c598c

TBR=tdanderson@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 687816 , 686234 , 686335 

Review-Url: https://codereview.chromium.org/2776973005
Cr-Commit-Position: refs/heads/master@{#459887}

[modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/BUILD.gn
[modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/power/power_status.cc
[modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/power/power_status.h
[modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/power/power_status_unittest.cc
[modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/session/tray_session_length_limit.cc
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/settings/tray_settings.cc
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/settings/tray_settings.h
[modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/ash_resources.grd
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/notification/notification_session_length_timer.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_brightness.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_power_small_all.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_power_small_all_dark.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_power_small_all_dark_fluctuating.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_power_small_all_fluctuating.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_settings.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/notification/notification_session_length_timer.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_brightness.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_power_small_all.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_power_small_all_dark.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_power_small_all_dark_fluctuating.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_power_small_all_fluctuating.png
[add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_settings.png

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8

commit 6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8
Author: estade <estade@chromium.org>
Date: Tue Mar 28 03:16:13 2017

retry cd95e0083676d5e: Remove some pre-md code and assets.

BUG= 687816 ,  686234 ,  686335 
TBR=tdanderson@chromium.org

Review-Url: https://codereview.chromium.org/2783503002
Cr-Commit-Position: refs/heads/master@{#459991}

[modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/BUILD.gn
[modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/power/power_status.cc
[modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/power/power_status.h
[modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/power/power_status_unittest.cc
[modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/session/tray_session_length_limit.cc
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/common/system/chromeos/settings/tray_settings.cc
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/common/system/chromeos/settings/tray_settings.h
[modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/resources/ash_resources.grd
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/notification/notification_session_length_timer.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_brightness.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_power_small_all.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_power_small_all_dark.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_power_small_all_dark_fluctuating.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_power_small_all_fluctuating.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_settings.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/notification/notification_session_length_timer.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_brightness.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_power_small_all.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_power_small_all_dark.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_power_small_all_dark_fluctuating.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_power_small_all_fluctuating.png
[delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_settings.png

Comment 7 by est...@chromium.org, Apr 17 2017

Status: Fixed (was: Started)
Labels: code-change
Status: Verified (was: Fixed)

Sign in to add a comment