New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687810 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove ShelfWidget::DelegateView::OnPaintBackground()

Project Member Reported by tdander...@chromium.org, Feb 2 2017

Issue description

Remove ShelfWidget::DelegateView::OnPaintBackground()
 
Status: Started (was: Assigned)
Labels: Hotlist-CodeHealth
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/273c082d54d0403ca0b7fb65729cee7ff25473f0

commit 273c082d54d0403ca0b7fb65729cee7ff25473f0
Author: bruthig <bruthig@chromium.org>
Date: Wed Feb 08 22:34:01 2017

[ash-md] Remove non-md code from the Shelf background animations.

This change removes the asset based background used by pre-material
design shelf animations.

BUG= 687810 
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2680113002
Cr-Commit-Position: refs/heads/master@{#449111}

[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/common/shelf/overflow_bubble_view.cc
[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/common/shelf/shelf_background_animator.cc
[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/common/shelf/shelf_background_animator.h
[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/common/shelf/shelf_background_animator_observer.h
[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/common/shelf/shelf_background_animator_unittest.cc
[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/common/shelf/shelf_constants.cc
[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/common/shelf/shelf_constants.h
[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/common/shelf/shelf_widget.cc
[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/common/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/273c082d54d0403ca0b7fb65729cee7ff25473f0/ash/resources/ash_resources.grd
[delete] https://crrev.com/ce3f7a721ca8dabb1b13ba506d9980d60c5e02ac/ash/resources/default_100_percent/common/shelf/shelf_background.png
[delete] https://crrev.com/ce3f7a721ca8dabb1b13ba506d9980d60c5e02ac/ash/resources/default_100_percent/common/shelf/shelf_corner.png
[delete] https://crrev.com/ce3f7a721ca8dabb1b13ba506d9980d60c5e02ac/ash/resources/default_200_percent/common/shelf/shelf_background.png
[delete] https://crrev.com/ce3f7a721ca8dabb1b13ba506d9980d60c5e02ac/ash/resources/default_200_percent/common/shelf/shelf_corner.png

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment