New issue
Advanced search Search tips

Issue 687805 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove non-MD code paths from the ShelfButton class

Project Member Reported by tdander...@chromium.org, Feb 2 2017

Issue description

Remove non-MD code paths from the ShelfButton class

 
Labels: Hotlist-CodeHealth

Comment 2 by moh...@chromium.org, Feb 24 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e883e24ee401658ae1537634f497a5a2bec5592f

commit e883e24ee401658ae1537634f497a5a2bec5592f
Author: mohsen <mohsen@chromium.org>
Date: Tue Feb 28 21:54:56 2017

Remove non-MD code from ShelfButton

BUG= 687805 
TEST=none

Review-Url: https://codereview.chromium.org/2712293002
Cr-Commit-Position: refs/heads/master@{#453713}

[modify] https://crrev.com/e883e24ee401658ae1537634f497a5a2bec5592f/ash/common/shelf/shelf_button.cc
[modify] https://crrev.com/e883e24ee401658ae1537634f497a5a2bec5592f/ash/common/shelf/shelf_button.h
[modify] https://crrev.com/e883e24ee401658ae1537634f497a5a2bec5592f/ash/common/shelf/shelf_constants.cc
[modify] https://crrev.com/e883e24ee401658ae1537634f497a5a2bec5592f/ash/common/shelf/shelf_constants.h
[modify] https://crrev.com/e883e24ee401658ae1537634f497a5a2bec5592f/ash/common/shelf/shelf_view.cc
[modify] https://crrev.com/e883e24ee401658ae1537634f497a5a2bec5592f/ash/resources/ash_resources.grd
[delete] https://crrev.com/f1d756b8310d09fcd4a3e7ab751c4e184c84d5b5/ash/resources/default_100_percent/common/shelf/shelf_underline_active.png
[delete] https://crrev.com/f1d756b8310d09fcd4a3e7ab751c4e184c84d5b5/ash/resources/default_100_percent/common/shelf/shelf_underline_attention.png
[delete] https://crrev.com/f1d756b8310d09fcd4a3e7ab751c4e184c84d5b5/ash/resources/default_100_percent/common/shelf/shelf_underline_running.png
[delete] https://crrev.com/f1d756b8310d09fcd4a3e7ab751c4e184c84d5b5/ash/resources/default_200_percent/common/shelf/shelf_underline_active.png
[delete] https://crrev.com/f1d756b8310d09fcd4a3e7ab751c4e184c84d5b5/ash/resources/default_200_percent/common/shelf/shelf_underline_attention.png
[delete] https://crrev.com/f1d756b8310d09fcd4a3e7ab751c4e184c84d5b5/ash/resources/default_200_percent/common/shelf/shelf_underline_running.png
[modify] https://crrev.com/e883e24ee401658ae1537634f497a5a2bec5592f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/e883e24ee401658ae1537634f497a5a2bec5592f/ash/test/shelf_view_test_api.cc
[modify] https://crrev.com/e883e24ee401658ae1537634f497a5a2bec5592f/ash/test/shelf_view_test_api.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment