New issue
Advanced search Search tips

Issue 687804 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove non-MD code paths from the TimeView class

Project Member Reported by tdander...@chromium.org, Feb 2 2017

Issue description

Remove non-MD code paths from the TimeView class
 
Labels: Hotlist-CodeHealth
Labels: -M-58 M-59

Comment 3 by est...@chromium.org, Mar 28 2017

Owner: est...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c921567339528ecf4dd25e5c68ef756d3ce17052

commit c921567339528ecf4dd25e5c68ef756d3ce17052
Author: estade <estade@chromium.org>
Date: Tue Mar 28 23:07:33 2017

More pre-MD cleanup

Remove TrayDate (unused in MD)
Remove non-MD code from TimeView
Remove assets
Remove non-MD code from SystemTray

BUG= 687804 , 686234 

Review-Url: https://codereview.chromium.org/2778143002
Cr-Commit-Position: refs/heads/master@{#460232}

[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/BUILD.gn
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/common/system/date/date_default_view.cc
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/common/system/date/date_default_view.h
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/date/date_view.cc
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/date/date_view.h
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/common/system/date/tray_date.cc
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/common/system/date/tray_date.h
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/default_system_tray_delegate.h
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/system_tray.h
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/resources/ash_resources.grd
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_help.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_help_hover.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_lockscreen.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_lockscreen_hover.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_shutdown.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_shutdown_hover.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_help.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_help_hover.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_lockscreen.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_lockscreen_hover.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_shutdown.png
[delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_shutdown_hover.png
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/app/resources/locale_settings.grd
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

Comment 5 by est...@chromium.org, Apr 17 2017

Status: Fixed (was: Started)
Labels: code-change
Status: Verified (was: Fixed)

Sign in to add a comment