New issue
Advanced search Search tips

Issue 687799 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cleanup of non-md code in OverflowBubbleView and and OverflowButton

Project Member Reported by tdander...@chromium.org, Feb 2 2017

Issue description

Remove the non-MD code paths from the OverflowBubbleView and and OverflowButton classes.

 
Labels: Hotlist-CodeHealth

Comment 2 by moh...@chromium.org, Feb 24 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4116d23962b4b90c6aebd76a7f9b2521441f3741

commit 4116d23962b4b90c6aebd76a7f9b2521441f3741
Author: mohsen <mohsen@chromium.org>
Date: Tue Feb 28 19:06:29 2017

Remove non-MD code from overflow button and bubble

BUG= 687799 
TEST=none

Review-Url: https://codereview.chromium.org/2714853004
Cr-Commit-Position: refs/heads/master@{#453655}

[modify] https://crrev.com/4116d23962b4b90c6aebd76a7f9b2521441f3741/ash/common/shelf/overflow_bubble_view.cc
[modify] https://crrev.com/4116d23962b4b90c6aebd76a7f9b2521441f3741/ash/common/shelf/overflow_button.cc
[modify] https://crrev.com/4116d23962b4b90c6aebd76a7f9b2521441f3741/ash/common/shelf/overflow_button.h
[modify] https://crrev.com/4116d23962b4b90c6aebd76a7f9b2521441f3741/ash/resources/ash_resources.grd
[delete] https://crrev.com/ca58fea9d8ea3d1e63abdc427f9a5326b581b2ae/ash/resources/default_100_percent/common/shelf/shelf_overflow.png
[delete] https://crrev.com/ca58fea9d8ea3d1e63abdc427f9a5326b581b2ae/ash/resources/default_100_percent/common/shelf/status_icon_background_normal.png
[delete] https://crrev.com/ca58fea9d8ea3d1e63abdc427f9a5326b581b2ae/ash/resources/default_100_percent/common/shelf/status_icon_background_pressed.png
[delete] https://crrev.com/ca58fea9d8ea3d1e63abdc427f9a5326b581b2ae/ash/resources/default_200_percent/common/shelf/shelf_overflow.png
[delete] https://crrev.com/ca58fea9d8ea3d1e63abdc427f9a5326b581b2ae/ash/resources/default_200_percent/common/shelf/status_icon_background_normal.png
[delete] https://crrev.com/ca58fea9d8ea3d1e63abdc427f9a5326b581b2ae/ash/resources/default_200_percent/common/shelf/status_icon_background_pressed.png

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment