New issue
Advanced search Search tips

Issue 687790 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Chromium OS build failure with minilayout: depends on vboot_reference

Reported by sumit....@gmail.com, Feb 2 2017

Issue description

Steps To Reproduce:
Follow the steps mentioned in https://www.chromium.org/chromium-os/developer-guide to build a chromium os image with minilayout option for arm-generic board

Expected Result:
Build completes successfully

Actual Result:
build_image fails with below logs:

INFO    : Generating license credits page. Time:

real    0m14.338s
user    0m6.036s
sys     0m0.208s
16:14:02: INFO: Searching for unused gconv files defined in /mnt/host/source/src/build/images/arm-generic/R58-9210.0.2017_01_23_1609-a1/rootfs/usr/lib/gconv/gconv-modules
16:14:03: INFO: Will search for 1131 strings in 34 files
16:14:04: INFO: Done. Using 56 gconv modules. Removed 190 unused modules (14452.4 KiB) and 2 unused dependencies (202.7 KiB)
/mnt/host/source/src/scripts/build_library/base_image_util.sh: line 241: /mnt/host/source/src/platform/vboot_reference/scripts/image_signing/insert_container_publickey.sh: No such file or directory
INFO    : Unmounting image from /mnt/host/source/src/build/images/arm-generic/R58-9210.0.2017_01_23_1609-a1/stateful and /mnt/host/source/src/build/images/arm-generic/R58-9210.0.2017_01_23_1609-a1/rootfs
Cleaning up /usr/local symlinks for /mnt/host/source/src/build/images/arm-generic/R58-9210.0.2017_01_23_1609-a1/stateful/dev_image
An error occurred in your build so your latest output directory is invalid.
---

How frequently does this problem reproduce? 
Always

What is the impact to the user, and is there a workaround? If so, what is
it?
Can get around this issue by checking out "chromeos-base/vboot_reference" project as below:
cros_workon --board=${BOARD} start chromeos-base/vboot_reference
repo sync chromiumos/platform/vboot_reference
cros_workon --board=${BOARD} stop chromeos-base/vboot_reference
./build_image --board=${BOARD} --noenable_rootfs_verification test


Please provide any additional information below. Attach a screen shot or
log if possible.
The issue looks generic enough to impact other boards as well.
 
Cc: dgreid@chromium.org davidri...@chromium.org vapier@chromium.org
Components: Build
Summary: Chromium OS build failure with minilayout: depends on vboot_reference (was: Chromium OS build failure with minilayout for arm-generic board (and possibly others as well))
Yeah, definitely looks like it affects all image builds for all architectures. Any thoughts on solutions? Or do we have to pull vboot_reference into minilayout?

IIUC, this script is essentially doing a single 'install' command for us...
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a84739d24eb6925269f2467ea0f6bc9480fdaa3b

commit a84739d24eb6925269f2467ea0f6bc9480fdaa3b
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Mar 13 09:54:14 2017

vboot_reference: install all image signing scripts in the sdk

This doesn't add a lot (scripts are <300kB), and we want some of these
when running build steps.  This way we avoid breakage w/minilayout.

BUG= chromium:687790 
TEST=precq passes

Change-Id: Iadf36dc61bea4d286ad5280da9a01b2e08549f51
Reviewed-on: https://chromium-review.googlesource.com/453202
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[modify] https://crrev.com/a84739d24eb6925269f2467ea0f6bc9480fdaa3b/chromeos-base/vboot_reference/vboot_reference-9999.ebuild

Looks like fixes are in flight.

Should there be some kind of minilayout tests on the waterfall? It appears only users noticed that build_image was broken for minilayout. A simple checkout + build would catch these errors.

Comment 4 by vapier@chromium.org, Mar 13 2017

seems like setting up a public incremental bot that uses minilayout wouldn't cost us too much
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/40cea039aa77c0241a8ca04abb2af39657784ca8

commit 40cea039aa77c0241a8ca04abb2af39657784ca8
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Mar 14 05:40:03 2017

switch vboot scripts/keys to installed sdk paths

This way we can work on minilayout setups.  Add a comment to prevent
future breakage.

BUG= chromium:687790 
TEST=precq passes

Change-Id: Id1eddf67d58d60868c8b31ca4310744cf43b224c
Reviewed-on: https://chromium-review.googlesource.com/453061
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[modify] https://crrev.com/40cea039aa77c0241a8ca04abb2af39657784ca8/common.sh

Comment 6 by vapier@chromium.org, Mar 14 2017

Owner: vapier@chromium.org
Status: Fixed (was: Unconfirmed)
should be set now in ToT.  lemme know if you guys still issues.

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Status: Fixed (was: Archived)

Sign in to add a comment