New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687789 link

Starred by 1 user
Status: Verified
Owner:
█ bruthig@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cleanup of Ash shelf background code

Project Member Reported by tdander...@chromium.org, Feb 2 2017 
Cleanup of items related to the Ash shelf background:

(1) Remove ShelfBackgroundAnimatorObserver::UpdateShelfAssetBackground().

(2) Remove the |asset_background_animator_| member from ShelfBackgroundAnimator.

(3) Replace all BackgroundAnimator members in ShelfBackgroundAnimator with a single gfx::SlideAnimation.

Comment 1 by tdander...@chromium.org, Feb 2 2017 

Also:

(4) Remove any other non-MD code paths still present in ShelfBackgroundAnimator / ShelfBackgroundAnimatorObserver.

Comment 2 by tdander...@chromium.org, Feb 7 2017

Labels: Hotlist-CodeHealth

Comment 3 by bruthig@chromium.org, Feb 24 2017

Status: Fixed (was: Assigned)
This was addressed by:
- https://codereview.chromium.org/2679333002/
- https://codereview.chromium.org/2680113002/

Comment 4 by rookrishna@chromium.org, Mar 29 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment