New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687786 link

Starred by 1 user
Status: Assigned
Owner:
moh...@chromium.org
Cc:
moh...@chromium.org
█ bruthig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 676410
Blocking:
issue 689280



Sign in to add a comment

Consider any further refactoring opportunities for code that initializes sticky header rows

Project Member Reported by tdander...@chromium.org, Feb 2 2017 
Consider using a TriView to manage the layout of section header rows in detailed views; see for instance the TODO in NetworkListViewMd::SectionHeaderRowView::InitializeLayout(). Other detailed views which will likely want to share the same layout code are:

* VPN
* Bluetooth (once issue 676410 is resolved)
* Audio
* MaterialKeyboardStatusRowView for IME; possibly related because it is defined as a 'sticky' header like the above three.

Comment 1 by tdander...@chromium.org, Feb 7 2017

Blocking: 689280

Comment 2 by tdander...@chromium.org, Feb 7 2017

Labels: Hotlist-CodeHealth

Comment 3 by tdander...@chromium.org, Feb 7 2017

Cc: bruthig@chromium.org
Owner: moh...@chromium.org

Comment 4 by tdander...@chromium.org, Mar 7 2017

Labels: -M-58 M-59

Comment 5 by moh...@chromium.org, Mar 28 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79aa71925e55322ad36bec0a19d42c62a060a2a9

commit 79aa71925e55322ad36bec0a19d42c62a060a2a9
Author: mohsen <mohsen@chromium.org>
Date: Tue Mar 28 23:56:58 2017

Remove an outdated TODO

The TODO is already addressed.

BUG=687786
TEST=none

Review-Url: https://codereview.chromium.org/2783753002
Cr-Commit-Position: refs/heads/master@{#460244}

[modify] https://crrev.com/79aa71925e55322ad36bec0a19d42c62a060a2a9/ash/common/system/chromeos/network/network_list_md.cc

Comment 7 by tdander...@chromium.org, Apr 3 2017

Status: Assigned (was: Started)
Summary: Consider any further refactoring opportunities for code that initializes sticky header rows (was: Consider sharing code to manage the layout of section header rows)
Re-purposing this bug slightly, we could take a look at all call sites of TrayPopupUtils::ConfigureAsStickyHeader() and see if there are any refactoring opportunities in the surrounding code.

Marking back as Assigned for the time being.

Comment 8 by tdander...@chromium.org, Apr 25 2017

Labels: -M-59 M-60
►

Sign in to add a comment