[Content Settings] Protected Content Section is Missing |
|||||
Issue descriptionThe Protected Content section (on Windows and ChromeOS) is currently missing from MD Settings. See screenshots for the ChromeOS look. Windows version lacks the exceptions button and dialog. This checkbox is also undergoing a UI redesign potentially finishing next week or the week after... My plan is to copy the existing functionality from Options over, and then edit it to accommodate the re-design afterwards. I expect most of the code will be shared.
,
Feb 2 2017
dschuyler, bettes: I'm adding a new section to MD Content Settings just so you guys know. It's so we have parity with Old Options. CrOS/Windows only.
,
Feb 2 2017
Thanks for the heads up, Tommy. If you'd like, assign this bug to me when the implementation can be viewed on our machines.
,
Feb 2 2017
bettes: I got a CL in progress. Here's two screenshots. Two questions I have: 1. What icon would you like to use for Protected Content? 2. Is last on the list good? Or different place?
,
Feb 2 2017
1. hardware:security 2. LGTM
,
Feb 3 2017
Hey Alan, one more thing. The old version has explanation text: "Some content services use machine identifiers to uniquely identify you for the purposes of authorizing access to protected content." That doesn't appear in the new version yet. Do you just want that as secondary text? Something else? Should we just wait for the re-design? (I'm assuming that's in progress now).
,
Feb 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e34f7eb3596b5ff981a4d1554bec36765e23f5d commit 2e34f7eb3596b5ff981a4d1554bec36765e23f5d Author: tommycli <tommycli@chromium.org> Date: Sat Feb 04 00:55:23 2017 MD Settings: Add Protected Content toggle to Site Settings Adds the toggle with the same text as the Old Options. The site exceptions portion is not included in this CL. BUG= 687783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2673783002 Cr-Commit-Position: refs/heads/master@{#448133} [modify] https://crrev.com/2e34f7eb3596b5ff981a4d1554bec36765e23f5d/chrome/app/settings_strings.grdp [modify] https://crrev.com/2e34f7eb3596b5ff981a4d1554bec36765e23f5d/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/2e34f7eb3596b5ff981a4d1554bec36765e23f5d/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/2e34f7eb3596b5ff981a4d1554bec36765e23f5d/chrome/browser/resources/settings/route.js [modify] https://crrev.com/2e34f7eb3596b5ff981a4d1554bec36765e23f5d/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/2e34f7eb3596b5ff981a4d1554bec36765e23f5d/chrome/browser/resources/settings/site_settings_page/site_settings_page.html [modify] https://crrev.com/2e34f7eb3596b5ff981a4d1554bec36765e23f5d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Feb 7 2017
,
Feb 7 2017
Issue 686886 has been merged into this issue.
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c3ce60724a6c3ac94ecd335effc7608cb045625 commit 0c3ce60724a6c3ac94ecd335effc7608cb045625 Author: tommycli <tommycli@chromium.org> Date: Tue Feb 07 01:24:17 2017 MD Settings: Add Protected Content Content Settings exceptions BUG= 687783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2673633003 Cr-Commit-Position: refs/heads/master@{#448493} [modify] https://crrev.com/0c3ce60724a6c3ac94ecd335effc7608cb045625/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/0c3ce60724a6c3ac94ecd335effc7608cb045625/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/0c3ce60724a6c3ac94ecd335effc7608cb045625/chrome/browser/resources/settings/site_settings/constants.js [modify] https://crrev.com/0c3ce60724a6c3ac94ecd335effc7608cb045625/chrome/test/data/webui/settings/site_list_tests.js [modify] https://crrev.com/0c3ce60724a6c3ac94ecd335effc7608cb045625/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad7fe40bd171138a8c8b31c7f68b5e05d6761ea6 commit ad7fe40bd171138a8c8b31c7f68b5e05d6761ea6 Author: tommycli <tommycli@chromium.org> Date: Tue Feb 07 01:29:34 2017 MD Settings: Add description for Protected Content Adds the explanation for Protected Content toggle. BUG= 687783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2677193004 Cr-Commit-Position: refs/heads/master@{#448497} [modify] https://crrev.com/ad7fe40bd171138a8c8b31c7f68b5e05d6761ea6/chrome/app/settings_strings.grdp [modify] https://crrev.com/ad7fe40bd171138a8c8b31c7f68b5e05d6761ea6/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/ad7fe40bd171138a8c8b31c7f68b5e05d6761ea6/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed4f8466dbb2bdc88bfee21b9ecabb16132b1316 commit ed4f8466dbb2bdc88bfee21b9ecabb16132b1316 Author: tommycli <tommycli@chromium.org> Date: Tue Feb 07 23:10:43 2017 MD Settings: Make Protected Content toggle change label text on toggle BUG= 687783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2677413002 Cr-Commit-Position: refs/heads/master@{#448772} [modify] https://crrev.com/ed4f8466dbb2bdc88bfee21b9ecabb16132b1316/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/ed4f8466dbb2bdc88bfee21b9ecabb16132b1316/chrome/browser/resources/settings/privacy_page/privacy_page.js
,
Feb 8 2017
Well now MD Settings has parity with Old Options, so I'm closing the bug. The version in Old Options is undergoing design changes right now, so I'll probably have to update MD Settings later... But -- this is no longer something that blocks Settings launch. Closing.
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/595de1b5cec1ba648843e33d2ee01957b4f5966c commit 595de1b5cec1ba648843e33d2ee01957b4f5966c Author: tommycli <tommycli@chromium.org> Date: Fri Feb 10 21:43:26 2017 MD Settings: Update Protected Content for redesign 1. Preserves settings.privacy.drm_enabled to toggle unique identifiers. 2. Adds webkit.webprefs.encrypted_media_enabled above to toggle EME. 3. Hides the exception list if prefs.settings.privacy.drm_enabled is disabled. BUG= 687783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2688793002 Cr-Commit-Position: refs/heads/master@{#449744} [modify] https://crrev.com/595de1b5cec1ba648843e33d2ee01957b4f5966c/chrome/app/settings_strings.grdp [modify] https://crrev.com/595de1b5cec1ba648843e33d2ee01957b4f5966c/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/595de1b5cec1ba648843e33d2ee01957b4f5966c/chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp [modify] https://crrev.com/595de1b5cec1ba648843e33d2ee01957b4f5966c/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/595de1b5cec1ba648843e33d2ee01957b4f5966c/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/595de1b5cec1ba648843e33d2ee01957b4f5966c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tommycli@chromium.org
, Feb 2 201732.2 KB
32.2 KB View Download