New issue
Advanced search Search tips

Issue 687781 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 691084



Sign in to add a comment

Remove synch_id

Project Member Reported by ayatane@chromium.org, Feb 2 2017

Issue description

Remove old synch_id concept from autotest

 
Blockedon: 691084
The database migration CL is getting reverted (again).
We've decided to do DB cleanups in one fell swoop.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2d3884ade80ee5a8e2316ddc0996e7a1a12d58da

commit 2d3884ade80ee5a8e2316ddc0996e7a1a12d58da
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Mon Mar 06 23:57:01 2017

Revert "[autotest] Remove synch_id from database"

This reverts commit c744f5fa4992f996768a4857c28fcc8045ea9df1.

Reason for revert: We don't want lab downtime today. We decided
to batch up some outstanding DB changes and do it in one fell
swoop. I'm just the executor...

Original change's description:
> [autotest] Remove synch_id from database
>
> BUG= chromium:687781 
> TEST=Run migrate.py sync back and forth
>
> Change-Id: Ieed2052c9aa6958cf3fb6081ee310499c233d112
> Reviewed-on: https://chromium-review.googlesource.com/449972
> Reviewed-by: Allen Li <ayatane@chromium.org>
> Commit-Queue: Allen Li <ayatane@chromium.org>
> Tested-by: Allen Li <ayatane@chromium.org>
>

TBR=pprabhu@chromium.org,xixuan@chromium.org,ayatane@chromium.org
BUG= chromium:687781 
BUG= chromium:691084 

Change-Id: Ia822a826f8f63dbe32c435adf9e4aea2045a6c3f
Reviewed-on: https://chromium-review.googlesource.com/450837
Reviewed-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/2d3884ade80ee5a8e2316ddc0996e7a1a12d58da/frontend/afe/rdb_model_extensions.py
[modify] https://crrev.com/2d3884ade80ee5a8e2316ddc0996e7a1a12d58da/frontend/afe/models_test.py
[modify] https://crrev.com/2d3884ade80ee5a8e2316ddc0996e7a1a12d58da/scheduler/scheduler_models.py
[modify] https://crrev.com/2d3884ade80ee5a8e2316ddc0996e7a1a12d58da/frontend/afe/doctests/001_rpc_test.txt
[add] https://crrev.com/2d3884ade80ee5a8e2316ddc0996e7a1a12d58da/frontend/migrations/113_add_back_sync_id_temporarily.py

Status: WontFix (was: Untriaged)
We actually want to keep this.

Sign in to add a comment