New issue
Advanced search Search tips

Issue 687779 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Safe Browsing certificate report URL is wrong

Project Member Reported by est...@chromium.org, Feb 2 2017

Issue description

During a certificate reporting refactoring as part of  issue 554323 , the certificate report upload URL was truncated, so we've been missing out on reports from several canaries.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13df10e53b1b9bd701917c981206c31405ad6b2d

commit 13df10e53b1b9bd701917c981206c31405ad6b2d
Author: estark <estark@chromium.org>
Date: Thu Feb 02 01:57:38 2017

Fix Safe Browsing cert reports URL

BUG= 687779 
TBR=jialiul@chromium.org

Review-Url: https://codereview.chromium.org/2676463002
Cr-Commit-Position: refs/heads/master@{#447683}

[modify] https://crrev.com/13df10e53b1b9bd701917c981206c31405ad6b2d/chrome/browser/safe_browsing/certificate_reporting_service.cc

Labels: Merge-Request-57
Status: Verified (was: Started)
I've verified the fix on canary. Requesting a merge for the commit in comment 1.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 3 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46c21fa105abe5e6da86dc0cfdfeb3034e2063ee

commit 46c21fa105abe5e6da86dc0cfdfeb3034e2063ee
Author: Emily Stark <estark@google.com>
Date: Fri Feb 03 18:54:26 2017

Fix Safe Browsing cert reports URL

BUG= 687779 
TBR=jialiul@chromium.org

Review-Url: https://codereview.chromium.org/2676463002
Cr-Commit-Position: refs/heads/master@{#447683}
(cherry picked from commit 13df10e53b1b9bd701917c981206c31405ad6b2d)

Review-Url: https://codereview.chromium.org/2677703003 .
Cr-Commit-Position: refs/branch-heads/2987@{#295}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/46c21fa105abe5e6da86dc0cfdfeb3034e2063ee/chrome/browser/safe_browsing/certificate_reporting_service.cc

Sign in to add a comment