New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687776 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 708190



Sign in to add a comment

All default menu rows should be using CreateMoreImageView() where applicable

Project Member Reported by tdander...@chromium.org, Feb 2 2017

Issue description

All default menu rows in the Ash MD system menu which contain an image on the right-hand side should be making use of CreateMoreImageView() in ash/common/system/tray/tray_popup_utils.h.

See the corresponding TODO in the abovementioned file.

 
Labels: Hotlist-CodeHealth
Labels: -M-58 M-59
Cc: bruthig@chromium.org
Owner: moh...@chromium.org

Comment 4 by moh...@chromium.org, Apr 13 2017

Status: Started (was: Assigned)

Comment 5 by moh...@chromium.org, Apr 13 2017

Blockedon: 708190
Owner: tdander...@chromium.org
Status: Assigned (was: Started)
The only place I've found that does not use CreateMoreImageView() for the right-hand side image is HoverHighlightView::AddRightIcon() which uses CreateMainImageView(). Assigning to tdanderson@ to take this into consideration in his HoverViewHighlight cleanup.

Comment 6 by moh...@chromium.org, Apr 13 2017

Cc: moh...@chromium.org
Labels: -M-59 M-60
Cc: tbuck...@chromium.org zork@chromium.org fukino@chromium.org
Owner: jamescook@chromium.org
Status: Untriaged (was: Assigned)
James, do you mind assisting with the re-triage of this ash/system code health bug?

tbuckley@, zork@, fukino@: FYI in case you know of a good owner.
Labels: Hotlist-GoodFirstBug
Owner: ----
To UI triage
Owner: manucornet@chromium.org
Status: Assigned (was: Untriaged)
Bulk-assigning unassigned status area bugs to me.
Labels: -M-60

Sign in to add a comment