New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687773 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Overview mode - allow moving selection and committing it using swipe gestures

Project Member Reported by varkha@chromium.org, Feb 2 2017

Issue description

Make it possible to use overview mode without getting fingers off the touchpad. Swipe up with 3 fingers enters overview mode. Swipe right or left with 3 fingers moves selection. Swipe down currently just dismisses the overview mode if no selection was made. With this change however if the selection was moved with a horizontal swipe, swipe down will accept this selection making a new window active.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/525b0d69b50807ab7c9901f52acf858c0e5e1ba8

commit 525b0d69b50807ab7c9901f52acf858c0e5e1ba8
Author: varkha <varkha@chromium.org>
Date: Fri Feb 10 19:28:14 2017

[ash-md] Adds support for gesture to move selection in overview mode

Make it possible to use overview mode without getting fingers off the
touchpad. Scroll up with 3 fingers enters overview mode. Scroll right
or left with 3 fingers moves selection. Scroll down dismisses overview
mode if no selection was made. If however the selection was moved with
a horizontal scroll, scroll down will accept this selection making a
new window active.

BUG= 687773 
TEST=OverviewGestureHandlerTest.HorizontalScrollInOverview

Review-Url: https://codereview.chromium.org/2667293002
Cr-Commit-Position: refs/heads/master@{#449687}

[modify] https://crrev.com/525b0d69b50807ab7c9901f52acf858c0e5e1ba8/ash/common/wm/overview/window_selector.cc
[modify] https://crrev.com/525b0d69b50807ab7c9901f52acf858c0e5e1ba8/ash/common/wm/overview/window_selector.h
[modify] https://crrev.com/525b0d69b50807ab7c9901f52acf858c0e5e1ba8/ash/common/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/525b0d69b50807ab7c9901f52acf858c0e5e1ba8/ash/common/wm/overview/window_selector_controller.h
[modify] https://crrev.com/525b0d69b50807ab7c9901f52acf858c0e5e1ba8/ash/wm/gestures/overview_gesture_handler.cc
[modify] https://crrev.com/525b0d69b50807ab7c9901f52acf858c0e5e1ba8/ash/wm/gestures/overview_gesture_handler.h
[modify] https://crrev.com/525b0d69b50807ab7c9901f52acf858c0e5e1ba8/ash/wm/gestures/overview_gesture_handler_unittest.cc

Comment 3 by varkha@chromium.org, Feb 10 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified on 58.0.3029.51

Sign in to add a comment