New issue
Advanced search Search tips

Issue 687756 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert ChannelMerger tests to use testharness

Project Member Reported by rtoy@chromium.org, Feb 2 2017

Issue description

Update tests to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb595a5e5abad3b90dd05419c3c10f9c47d3976d

commit bb595a5e5abad3b90dd05419c3c10f9c47d3976d
Author: rtoy <rtoy@chromium.org>
Date: Thu Feb 02 20:07:06 2017

Convert ChannelMerger Audit tests to testharness

These tests were converted to use testharness via the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

However, audiochannelmerger-cycle.html needed some hand-modifications
because of the use of testPassed/testFailed. Also, fixed minor issue
in the code where there was a loop that ran the test twice
unnecessarily.

BUG= 687756 
TEST=audiochannelmerger-basic.html, audiochannelmerger-cycle.html,
audiochannelmerger-disconnect.html,
audiochannelmerger-input-non-default.html,
audiochannelmerger-input.html

Review-Url: https://codereview.chromium.org/2670643003
Cr-Commit-Position: refs/heads/master@{#447828}

[delete] https://crrev.com/97ff0cb5ef86c8b881334c333f37fd4baa2b216c/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-basic-expected.txt
[modify] https://crrev.com/bb595a5e5abad3b90dd05419c3c10f9c47d3976d/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-basic.html
[delete] https://crrev.com/97ff0cb5ef86c8b881334c333f37fd4baa2b216c/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-cycle-expected.txt
[modify] https://crrev.com/bb595a5e5abad3b90dd05419c3c10f9c47d3976d/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-cycle.html
[delete] https://crrev.com/97ff0cb5ef86c8b881334c333f37fd4baa2b216c/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-disconnect-expected.txt
[modify] https://crrev.com/bb595a5e5abad3b90dd05419c3c10f9c47d3976d/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-disconnect.html
[delete] https://crrev.com/97ff0cb5ef86c8b881334c333f37fd4baa2b216c/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-input-expected.txt
[delete] https://crrev.com/97ff0cb5ef86c8b881334c333f37fd4baa2b216c/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-input-non-default-expected.txt
[modify] https://crrev.com/bb595a5e5abad3b90dd05419c3c10f9c47d3976d/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-input-non-default.html
[modify] https://crrev.com/bb595a5e5abad3b90dd05419c3c10f9c47d3976d/third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-input.html

Comment 2 by rtoy@chromium.org, Feb 3 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Comment 3 by rtoy@chromium.org, Feb 3 2017

Blocking: 623160

Sign in to add a comment