New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687754 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.3% regression in system_health.memory_mobile at 447012:447107

Project Member Reported by pmeenan@chromium.org, Feb 2 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=687754

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgiJ2w8QoM


Bot(s) for this bug's original alert(s):

android-one
Cc: jkummerow@chromium.org
Owner: jkummerow@chromium.org

=== Auto-CCing suspected CL author jkummerow@chromium.org ===

Hi jkummerow@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jkummerow
  Commit : e42da75c9eaa604353623b0bb17051513f05410a
  Date   : Mon Jan 30 18:56:19 2017
  Subject: [stubs] KeyedLoadIC_Generic: prototype chain lookup support (reland)

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/load_news/load_news_hackernews
  Change       : 1.68% | 1989245.33333 -> 2022603.33333

Revision                           Result                  N
chromium@447011                    1989245 +- 20856.2      6      good
chromium@447059                    1989913 +- 19830.1      6      good
chromium@447083                    1995459 +- 22945.3      6      good
chromium@447095                    1991351 +- 22255.8      6      good
chromium@447098                    1989913 +- 19830.1      6      good
chromium@447099                    1996851 +- 16215.9      6      good
chromium@447099,v8@dc85f4c833      1998702 +- 17917.8      6      good
chromium@447099,v8@e42da75c9e      2017161 +- 20477.0      6      bad       <--
chromium@447099,v8@c0f255f075      2019160 +- 30249.3      6      bad
chromium@447100                    2021975 +- 16123.9      6      bad
chromium@447101                    2019202 +- 25283.6      6      bad
chromium@447107                    2022603 +- 20779.3      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.hackernews system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8988816459446375440

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5824245583577088


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: WontFix (was: Untriaged)
Given the flakiness and error margins of the measured values, those graphs need much finer (= closer to per-commit) granularity. The bisection results indicate that memory consumption crept up slowly between 447011 and 447107.

The referenced CL does increase memory consumption a bit (in exchange for higher performance, so that's working as intended), but there's no way it's responsible for the entire increase detected here.
Labels: Performance-Memory

Sign in to add a comment