New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687750 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Media Remoting should never admit initialization failed

Project Member Reported by m...@chromium.org, Feb 1 2017

Issue description

During testing, an error occurred while starting Media Remoting, and this left the user with a broken video player in the page. Instead, the fallback-to-mirroring should have engaged and the video player in the page should have continued normally by falling-back to the normal local media::Renderer (plus traditional tab capture mirroring).

The error occurred while the media pipeline was initializing the CourierRenderer, and the CourierRenderer reported this failure back to the media pipeline. Instead, it should always report success to the media pipeline, and then become a no-op renderer after that point. The idea: Because of the Media Remoting error, the Media Remoting session will soon end, and the CourierRenderer will be switched with a normal local media::Renderer. We want the media pipeline to be in a non-error state so that it will happily switch to using this new local renderer.
 

Comment 1 by x...@chromium.org, Feb 2 2017

Owner: x...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa3876bfc4b420d126b2a52f653b3bbb13944de5

commit fa3876bfc4b420d126b2a52f653b3bbb13944de5
Author: xjz <xjz@chromium.org>
Date: Fri Feb 03 03:44:56 2017

Media Remoting: Don't report remote renderer init error to pipeline.

When error occurs during initializing the remote renderer,
CourierRenderer should not report the failure to media pipeline.
Instead, it should always report success to the media pipeline, and
then become a no-op renderer after that point.  The remoting session
will soon end, and a normal local renderer will be created instead.

BUG= 687750 

Review-Url: https://codereview.chromium.org/2669033004
Cr-Commit-Position: refs/heads/master@{#447911}

[modify] https://crrev.com/fa3876bfc4b420d126b2a52f653b3bbb13944de5/media/remoting/courier_renderer.cc
[modify] https://crrev.com/fa3876bfc4b420d126b2a52f653b3bbb13944de5/media/remoting/courier_renderer_unittest.cc

Comment 3 by x...@chromium.org, Feb 8 2017

Status: Fixed (was: Started)

Comment 4 by x...@chromium.org, Feb 10 2017

Labels: -M-57 M-58

Sign in to add a comment