MD Settings : Message missing on top of Settings page when multiple sign-in is being used. |
|||||||||||
Issue descriptionGoogle Chrome 57.0.2987.19 (Official Build) dev (32-bit) Revision 0 Platform 9202.12.0 (Official Build) dev-channel veyron_minnie What steps will reproduce the problem? 1. Log-in to user account 2. Open uber tray and Sign-in another user 3. Open settings page on the second user account What is the expected result? Should see below message on top of settings page "Some settings belonging to <user> are being shared with you. These settings only affect your account when using multiple sign-in." What happens instead? No message is seen. Attached screenshots from md-settings and non-md-settings pages
,
Feb 8 2017
,
Feb 9 2017
,
Feb 9 2017
Tom, Alan, do we have mocks for the MD version of this?
,
Feb 9 2017
Attached a screenshot of what I have currently. LMKWYT.
,
Feb 13 2017
Thanks Steven! Contents look good to me, not sure about the spacing around the card though. Assigning to bettes to take a look.
,
Feb 14 2017
,
Feb 14 2017
Alan mentioned today that maybe instead of a one-off banner we could somehow incorporate this into the people section or page?
,
Feb 14 2017
We have indicators throughout the page when in multi-profile mode, but we still want some alert at the top of the page so users know why major sections are unavailable (eg. wifi)
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27725d345f9b9044e8534f3f0e3bad0e0a0a893b commit 27725d345f9b9044e8534f3f0e3bad0e0a0a893b Author: stevenjb <stevenjb@chromium.org> Date: Tue Feb 14 22:04:46 2017 MD Settings: CrOS: Add secondary user banner BUG= 687749 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2687643004 Cr-Commit-Position: refs/heads/master@{#450486} [modify] https://crrev.com/27725d345f9b9044e8534f3f0e3bad0e0a0a893b/chrome/app/settings_strings.grdp [modify] https://crrev.com/27725d345f9b9044e8534f3f0e3bad0e0a0a893b/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/27725d345f9b9044e8534f3f0e3bad0e0a0a893b/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/27725d345f9b9044e8534f3f0e3bad0e0a0a893b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Feb 14 2017
Lowering priority now that we have a solution in. We can improve the look of it when the UX is ready. Also removing this as a blocker for the launch bug ( issue 684849 ). We should aim to have the improved UX in, but it needn't block the launch. Notes: a) Multi-profile is not (to the best of my knowledge) widely used (outside of Chrome developers). b) Some important Settings (e.g. with privacy concerns) have been identified as primary-user only (e.g. Internet Settings), but we did not thoroughly audit Settings when we launched the feature. e.g. paired Bluetooth devices and available input methods will be stored with the Primary user, even though the can be added/removed by a secondary user. c) The banner at the top of Settings was added partly to address (b).
,
Feb 14 2017
Re: paired bluetooth devices -- when we adjusted settings for multiple sign-in, Bluetooth info was stored at a device level and so it was fine to show them in both primary & secondary settings. These documents may be useful for completing multiple sign-in work: - PRD: https://docs.google.com/document/d/1G09Mql1TtVFA4qhb7hlt4u2crBv6_fhrZMf40Yo--lc/edit#heading=h.2q8z0629yzq0 - Analysis spreadsheet: https://docs.google.com/spreadsheets/d/1HzSDoy1TRCGCDzFMnfQQ8Jif-Fi_iavfgnpZxachV34/edit#gid=0
,
Mar 3 2017
,
May 8 2017
Let's just keep the existing banner since this is not a popular feature. @stevenjb is anything else needed?
,
May 8 2017
Nope, marking fixed then.
,
May 12 2017
9542.0.0, 60.0.3096.0 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by omrilio@chromium.org
, Feb 7 2017Status: Assigned (was: Untriaged)