Align exo shadow underlay at pixel boundary
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba48072770ed46f3328f09d8147f42c8cf4a1677 commit ba48072770ed46f3328f09d8147f42c8cf4a1677 Author: oshima <oshima@chromium.org> Date: Tue Feb 07 04:51:16 2017 Use pixel coordinates for shadow underlay bounds * Introduced new request set_rectangular_surface_shadow. Reprecated old one. * Added placeholder for set/unset moving introduced in remote_surface version 2. This only switches the underlay to pixel and that looks good enough to me. I'll work on the shadow itself separately if necessary. BUG= 687742 TEST=tested on Elm. Review-Url: https://codereview.chromium.org/2664403004 Cr-Commit-Position: refs/heads/master@{#448549} [modify] https://crrev.com/ba48072770ed46f3328f09d8147f42c8cf4a1677/components/exo/shell_surface.cc [modify] https://crrev.com/ba48072770ed46f3328f09d8147f42c8cf4a1677/components/exo/shell_surface.h [modify] https://crrev.com/ba48072770ed46f3328f09d8147f42c8cf4a1677/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/ba48072770ed46f3328f09d8147f42c8cf4a1677/components/exo/wayland/server.cc [modify] https://crrev.com/ba48072770ed46f3328f09d8147f42c8cf4a1677/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h [modify] https://crrev.com/ba48072770ed46f3328f09d8147f42c8cf4a1677/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h [modify] https://crrev.com/ba48072770ed46f3328f09d8147f42c8cf4a1677/third_party/wayland-protocols/protocol/remote-shell-protocol.c [modify] https://crrev.com/ba48072770ed46f3328f09d8147f42c8cf4a1677/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
Approving merge to M57 Chrome OS.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97bbe761db423525796e492d568e0ebc64af6b24 commit 97bbe761db423525796e492d568e0ebc64af6b24 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Feb 08 19:48:13 2017 Use pixel coordinates for shadow underlay bounds * Introduced new request set_rectangular_surface_shadow. Reprecated old one. * Added placeholder for set/unset moving introduced in remote_surface version 2. This only switches the underlay to pixel and that looks good enough to me. I'll work on the shadow itself separately if necessary. BUG= 687742 TEST=tested on Elm. Review-Url: https://codereview.chromium.org/2664403004 Cr-Commit-Position: refs/heads/master@{#448549} (cherry picked from commit ba48072770ed46f3328f09d8147f42c8cf4a1677) Review-Url: https://codereview.chromium.org/2686533004 . Cr-Commit-Position: refs/branch-heads/2987@{#391} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/97bbe761db423525796e492d568e0ebc64af6b24/components/exo/shell_surface.cc [modify] https://crrev.com/97bbe761db423525796e492d568e0ebc64af6b24/components/exo/shell_surface.h [modify] https://crrev.com/97bbe761db423525796e492d568e0ebc64af6b24/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/97bbe761db423525796e492d568e0ebc64af6b24/components/exo/wayland/server.cc [modify] https://crrev.com/97bbe761db423525796e492d568e0ebc64af6b24/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h [modify] https://crrev.com/97bbe761db423525796e492d568e0ebc64af6b24/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h [modify] https://crrev.com/97bbe761db423525796e492d568e0ebc64af6b24/third_party/wayland-protocols/protocol/remote-shell-protocol.c [modify] https://crrev.com/97bbe761db423525796e492d568e0ebc64af6b24/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da082c748163f71334651cc9d7506d18b2e169e9 commit da082c748163f71334651cc9d7506d18b2e169e9 Author: oshima <oshima@chromium.org> Date: Thu Feb 09 21:30:08 2017 Skip UpdateShadow if the surface has already been destroyed BUG= 690515 , 687742 Review-Url: https://codereview.chromium.org/2681233003 Cr-Commit-Position: refs/heads/master@{#449415} [modify] https://crrev.com/da082c748163f71334651cc9d7506d18b2e169e9/components/exo/shell_surface.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9eac9bcd626246dfab4b350a50ae470b0f7b2dd commit f9eac9bcd626246dfab4b350a50ae470b0f7b2dd Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Feb 13 01:34:22 2017 Skip UpdateShadow if the surface has already been destroyed BUG= 690515 , 687742 Review-Url: https://codereview.chromium.org/2681233003 Cr-Commit-Position: refs/heads/master@{#449415} (cherry picked from commit da082c748163f71334651cc9d7506d18b2e169e9) Review-Url: https://codereview.chromium.org/2690713002 . Cr-Commit-Position: refs/branch-heads/2987@{#470} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/f9eac9bcd626246dfab4b350a50ae470b0f7b2dd/components/exo/shell_surface.cc
Comment 1 by bugdroid1@chromium.org
, Feb 7 2017