New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687737 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

speedometer times out frequently

Project Member Reported by laszio@chromium.org, Feb 1 2017

Issue description

02/01 14:46:59.322 INFO |telemetry_AFDOGene:0195| Starting run for Telemetry benchmark speedometer
02/01 14:46:59.322 DEBUG|  telemetry_runner:0382| Running telemetry benchmark: speedometer
02/01 14:46:59.323 DEBUG|  telemetry_runner:0314| Running Telemetry: ssh 100.115.185.226 python /home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/tools/perf/run_benchmark --verbose --browser=cros-chrome --output-format=chartjson --output-dir=/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src --remote=chromeos6-row2-rack7-host22 speedometer
02/01 14:46:59.323 DEBUG|  telemetry_runner:0275| Running: ssh 100.115.185.226 python /home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/tools/perf/run_benchmark --verbose --browser=cros-chrome --output-format=chartjson --output-dir=/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src --remote=chromeos6-row2-rack7-host22 speedometer
02/01 14:46:59.323 DEBUG|        base_utils:0185| Running 'ssh 100.115.185.226 python /home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/tools/perf/run_benchmark --verbose --browser=cros-chrome --output-format=chartjson --output-dir=/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src --remote=chromeos6-row2-rack7-host22 speedometer'
02/01 14:48:35.585 DEBUG|  telemetry_runner:0286| Error occurred executing.
02/01 14:48:35.585 DEBUG|  telemetry_runner:0292| Completed with exit code: 1.
stdout:[ RUN      ] http://browserbench.org/Speedometer/
Traceback (most recent call last):
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 94, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 301, in RunStory
    self._current_page, self._current_tab, results)
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/tools/perf/benchmarks/speedometer.py", line 72, in ValidateAndMeasurePage
    timemout=600)
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 209, in WaitForJavaScriptCondition2
    return self._inspector_backend.WaitForJavaScriptCondition2(*args, **kwargs)
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 294, in WaitForJavaScriptCondition2
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 60s for IsJavaScriptExpressionTrue.
Console output:
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember      : 1.3.1
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember Data : 1.0.0-beta.6
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Handlebars : 1.3.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: jQuery     : 2.1.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: For more advanced debugging, install the Ember Inspector from https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember      : 1.3.1
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember Data : 1.0.0-beta.6
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Handlebars : 1.3.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: jQuery     : 2.1.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: For more advanced debugging, install the Ember Inspector from https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember      : 1.3.1
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember Data : 1.0.0-beta.6
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Handlebars : 1.3.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: jQuery     : 2.1.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: For more advanced debugging, install the Ember Inspector from https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember      : 1.3.1
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember Data : 1.0.0-beta.6
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Handlebars : 1.3.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: jQuery     : 2.1.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: For more advanced debugging, install the Ember Inspector from https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember      : 1.3.1
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Ember Data : 1.0.0-beta.6
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: Handlebars : 1.3.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: jQuery     : 2.1.0
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: -------------------------------
(debug) http://browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:3285: DEBUG: For more advanced debugging, install the Ember Inspector from https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi


[  FAILED  ] http://browserbench.org/Speedometer/ (88074 ms)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ]  http://browserbench.org/Speedometer/

 
Cc: cbruni@chromium.org
Owner: perezju@chromium.org
Status: Assigned (was: Untriaged)
Hmhh, the code says to wait for 600s, but then it times out after 60s. I am suspecting this is bug related to Juan's refactoring work.
  File "/home/chromeos-test/images/lumpy-chrome-pfq/R58-9241.0.0-rc1/telemetry_src/src/tools/perf/benchmarks/speedometer.py", line 72, in ValidateAndMeasurePage
    timemout=600)

"timemout" oops, yep, that was me.

I'll fix that and add some more validation on the args of the new API.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41cbaaac04a5e4a31285b8794fb02d80bb777f0f

commit 41cbaaac04a5e4a31285b8794fb02d80bb777f0f
Author: perezju <perezju@chromium.org>
Date: Thu Feb 02 11:07:56 2017

[tools/perf] Fix typo in speedometer page measurement

A typo was introduced during a recent refactor.

BUG= 687737 
TBR=nednguyen@google.com

Review-Url: https://codereview.chromium.org/2673483003
Cr-Commit-Position: refs/heads/master@{#447740}

[modify] https://crrev.com/41cbaaac04a5e4a31285b8794fb02d80bb777f0f/tools/perf/benchmarks/speedometer.py

Status: Fixed (was: Assigned)
Should be fixed now.

CL with fix to prevent this happening again in the future also out for review: https://codereview.chromium.org/2671693002/
Cc: mvstan...@chromium.org hablich@chromium.org machenb...@chromium.org nedngu...@google.com bmeu...@chromium.org
 Issue 687681  has been merged into this issue.

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment