New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687715 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 620813



Sign in to add a comment

Use the correct version for stability reports

Project Member Reported by manzagop@chromium.org, Feb 1 2017

Issue description

Right now we use the version of the reporter instead of that of the crasher. Change this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b9a40a37854fe18d08e55421d05f69973a6038d

commit 6b9a40a37854fe18d08e55421d05f69973a6038d
Author: manzagop <manzagop@chromium.org>
Date: Tue Feb 14 15:51:39 2017

Switch stability reports to use the crashed version's details

Prior to this CL we report the reporter's version details. This CL
switches to using the crasher's version. The reporter's version is
added to the report as global data.

There may be cases in which the crasher's version details are missing.
This CL assumes this is rare. In such cases, no report is sent but we log
to ActivityTracker.Collect.MissingProductDetails.

BUG= 687715 

Review-Url: https://codereview.chromium.org/2685053003
Cr-Commit-Position: refs/heads/master@{#450367}

[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/BUILD.gn
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/postmortem_minidump_writer.h
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/postmortem_minidump_writer_win.cc
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/postmortem_minidump_writer_win_unittest.cc
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/postmortem_report_collector.cc
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/postmortem_report_collector.h
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/stability_data_names.cc
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/stability_data_names.h
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/components/browser_watcher/stability_report.proto
[modify] https://crrev.com/6b9a40a37854fe18d08e55421d05f69973a6038d/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment