Now that mus uses Shell there is no reason to have WmShell implementations. We still need some differences between classic ash and mus. Those should exist in ShellMus and ShellClassic.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00c813f8b366562e6af4ace846ebd302cc0e475a commit 00c813f8b366562e6af4ace846ebd302cc0e475a Author: sky <sky@chromium.org> Date: Wed Mar 08 22:48:55 2017 Moves maintaining ShellObservers back to Shell BUG= 687660 TEST=none R=msw@chromium.org,reveman@chromium.org Review-Url: https://codereview.chromium.org/2739763003 Cr-Commit-Position: refs/heads/master@{#455569} [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/accelerators/accelerator_interactive_uitest_chromeos.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/aura/wm_shell_aura.h [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/frame/header_view.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/shelf/shelf_layout_manager.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/shelf/shelf_locking_manager.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/shelf/wm_shelf.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/system/chromeos/brightness/tray_brightness.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/system/chromeos/cast/tray_cast.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/system/chromeos/palette/palette_tray.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/system/chromeos/screen_security/screen_capture_tray_item.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/system/chromeos/session/logout_confirmation_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/system/overview/overview_button_tray.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/system/web_notification/ash_popup_alignment_delegate.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/test/test_shelf_delegate.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/dock/docked_window_layout_manager.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/lock_layout_manager.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/maximize_mode/maximize_mode_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/overview/window_selector_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/panels/panel_frame_view.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/screen_dimmer.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm_shell.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/common/wm_shell.h [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/display/shutdown_observer_chromeos.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/high_contrast/high_contrast_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/root_window_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/shelf/shelf_widget_unittest.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/shell.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/shell.h [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/system/chromeos/power/tablet_power_button_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/system/chromeos/power/video_activity_notifier.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/system/chromeos/rotation/tray_rotation_lock.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/wm/panels/attached_panel_window_targeter.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/wm/screen_pinning_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/ash/wm/video_detector.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/chrome/browser/chromeos/policy/display_rotation_default_handler.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/chrome/browser/chromeos/preferences.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/chrome/browser/notifications/login_state_notification_blocker_chromeos.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/00c813f8b366562e6af4ace846ebd302cc0e475a/components/exo/wm_helper_ash.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f07aff743bb84efec231eb4f6917b2e72dd515f6 commit f07aff743bb84efec231eb4f6917b2e72dd515f6 Author: sky <sky@chromium.org> Date: Thu Mar 09 06:00:40 2017 Removes WmShell::NewWindow() Instead code can create the window directly. I've also added the WindowType to the constructor of aura::Window to make the common task of creating a window then setting the type slightly easier. BUG= 687660 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2733303004 Cr-Commit-Position: refs/heads/master@{#455677} [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/aura/wm_shell_aura.h [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/common/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/common/test/ash_test.cc [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/common/wm/window_dimmer.cc [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/common/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/common/wm_shell.h [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/common/wm_window_user_data_unittest.cc [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ash/root_window_controller.cc [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ui/aura/window.cc [modify] https://crrev.com/f07aff743bb84efec231eb4f6917b2e72dd515f6/ui/aura/window.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07a24d4e93c52240de9d3dd799657e976c64df7a commit 07a24d4e93c52240de9d3dd799657e976c64df7a Author: sky <sky@chromium.org> Date: Thu Mar 09 23:57:30 2017 Promotes a handful of members from WmShell to Shell This is the set of objects created by what was WmShell::Initialize(). BUG= 687660 TEST=covered by tests R=msw@chromium.org, sadrul@chromium.org, elijahtaylor@chromium.org, reveman@chromium.org TBR=reveman@chromium.org Review-Url: https://codereview.chromium.org/2738133003 Cr-Commit-Position: refs/heads/master@{#455910} [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/DEPS [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/accelerators/spoken_feedback_toggler.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/accelerators/spoken_feedback_toggler_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/DEPS [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/accelerators/debug_commands.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/devtools/ash_devtools_dom_agent.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/devtools/ash_devtools_dom_agent.h [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/devtools/ash_devtools_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/keyboard/keyboard_ui.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/mojo_interface_factory.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/shelf/shelf_widget.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/chromeos/palette/palette_tray.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/chromeos/palette/tools/capture_region_mode.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/chromeos/palette/tools/capture_screen_action.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/chromeos/palette/tools/create_note_action.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/chromeos/palette/tools/create_note_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/chromeos/palette/tools/screenshot_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/chromeos/tray_caps_lock.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/ime/tray_ime_chromeos.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/ime/tray_ime_chromeos_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/tray/system_tray_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/system/tray_accessibility.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/wallpaper/wallpaper_view.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/wm/dock/docked_window_layout_manager.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/wm_shell.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/common/wm_shell.h [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/default_wallpaper_delegate.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/magnifier/magnification_controller.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/mus/context_menu_mus.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/shell.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/shell.h [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/system/chromeos/power/tablet_power_button_controller.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/test/shell_test_api.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/test/shell_test_api.h [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/test/test_wallpaper_delegate.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/wm/lock_state_controller.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/login/kiosk_browsertest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/components/arc/intent_helper/arc_intent_helper_bridge.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/components/exo/wm_helper_ash.cc [modify] https://crrev.com/07a24d4e93c52240de9d3dd799657e976c64df7a/ui/arc/notification/arc_notification_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b073203afbe9bd42ecb403983e04a947f5023f5e commit b073203afbe9bd42ecb403983e04a947f5023f5e Author: sky <sky@chromium.org> Date: Mon Mar 13 16:59:16 2017 chromeos: Promotes more from WmShell to Shell Specifically ShellDelegate, PrefClientStore and WallpaperDelegate. I also added Shell::Get() and deprecated GetInstance(). Will rename closer to branch. BUG= 687660 TEST=covered by tests R=elijahtaylor@chromium.org, jamescook@chromium.org, rockot@chromium.org TBR=rockot@chromium.org Review-Url: https://codereview.chromium.org/2741273002 Cr-Commit-Position: refs/heads/master@{#456403} [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/DEPS [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/accelerators/accelerator_controller_delegate_aura.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/aura/wm_shell_aura.h [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/DEPS [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/accelerators/debug_commands.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/accelerators/exit_warning_handler.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/shelf/shelf_view.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/shutdown_controller.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/system/user/tray_user_unittest.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/system/user/user_view.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/wallpaper/wallpaper_view.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/wallpaper/wallpaper_widget_controller.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/wm/focus_rules.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/wm_shell.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/common/wm_shell.h [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/mus/context_menu_mus.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/mus/window_manager.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/root_window_controller.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/shell.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/shell.h [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/system/chromeos/power/tablet_power_button_controller.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/wm/lock_state_controller.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/ash/wm/window_positioner_unittest.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/chrome/browser/chromeos/arc/print/arc_print_service.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/chrome/browser/ui/ash/launcher/launcher_context_menu.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc [modify] https://crrev.com/b073203afbe9bd42ecb403983e04a947f5023f5e/components/arc/intent_helper/arc_intent_helper_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e commit 7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e Author: sky <sky@chromium.org> Date: Tue Mar 14 21:52:29 2017 Moves app_list() and related functions from Shell to WmShell BUG= 687660 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2750483005 Cr-Commit-Position: refs/heads/master@{#456850} [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/accelerators/accelerator_filter_unittest.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/accelerators/accelerator_interactive_uitest_chromeos.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/app_list/app_list_delegate_impl.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/common/accelerators/accelerator_router.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/common/mojo_interface_factory.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/common/shelf/app_list_button.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/common/shelf/app_list_shelf_item_delegate.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/common/wm_shell.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/common/wm_shell.h [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/shell.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/shell.h [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/shell/app_list.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/shell/content/client/shell_browser_main_parts.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc [modify] https://crrev.com/7db5ccf2a7af8d8a933ed1a0589059bcaa1bf44e/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81a2d796ecde51050ebf057af9426b251cad9028 commit 81a2d796ecde51050ebf057af9426b251cad9028 Author: sky <sky@chromium.org> Date: Fri Mar 17 19:14:39 2017 Move AcceleratorController from WmShell to Shell Also moves AcceleratorControllerDelegateAura from Shell to WmShellAura. Access to AcceleratorControllerDelegateAura is now only WmShellAura to reinforce AcceleratorControllerDelegateAura is only in classic aura. BUG= 687660 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2752593008 Cr-Commit-Position: refs/heads/master@{#457843} [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/aura/wm_shell_aura.h [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/common/accelerators/accelerator_router.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/common/accelerators/ash_focus_manager_factory.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/common/mojo_interface_factory.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/common/system/tray/system_tray_unittest.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/common/wm_shell.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/common/wm_shell.h [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/mus/accelerators/accelerator_controller_registrar.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/shell.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/shell.h [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/test/ash_test_helper.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/wm/power_button_controller.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/ash/wm/screen_pinning_controller_unittest.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/extensions/api/automation/automation_apitest.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/extensions/global_shortcut_listener_chromeos.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/ui/ash/accelerator_controller_browsertest.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/ui/ash/ash_init.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/ui/ash/ash_util.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/ui/ash/palette_delegate_chromeos.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/ui/browser_commands_chromeos.cc [modify] https://crrev.com/81a2d796ecde51050ebf057af9426b251cad9028/chrome/browser/ui/views/chrome_views_delegate_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79fa3471cea36082fa33d26b452878490b9cba84 commit 79fa3471cea36082fa33d26b452878490b9cba84 Author: sky <sky@chromium.org> Date: Mon Mar 20 23:46:47 2017 Move more from WmShell to Shell Most aren't related, but a couple are. I'm doing this in chunks to avoid mongo-patches. BUG= 687660 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2761063002 Cr-Commit-Position: refs/heads/master@{#458242} [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/aura/wm_shell_aura.h [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/mojo_interface_factory.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/shelf/shelf_widget.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/shelf/wm_shelf.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/brightness/tray_brightness.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/cast/tray_cast.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/enterprise/tray_enterprise.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/ime_menu/ime_list_view.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/network/network_state_list_detailed_view.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/network/vpn_list_view.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/palette/palette_tray.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/power/dual_role_notification.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/session/logout_button_tray.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/session/logout_confirmation_controller.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/session/tray_session_length_limit.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/settings/tray_settings.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/supervised/tray_supervised_user.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/tray_caps_lock.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/tray_tracing.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/date/date_default_view.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/date/date_view.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/ime/tray_ime_chromeos.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/overview/overview_button_tray.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/status_area_widget.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/status_area_widget_delegate.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/tiles/tiles_default_view.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/tray/system_tray_bubble.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/tray_accessibility.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/update/tray_update.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/update/tray_update_unittest.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/user/tray_user.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/user/user_card_view.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/user/user_view.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/test/ash_test.cc [delete] https://crrev.com/3c7d798abb3a42da2bdaeeb0497a47575fda9bd2/ash/common/test/wm_shell_test_api.cc [delete] https://crrev.com/3c7d798abb3a42da2bdaeeb0497a47575fda9bd2/ash/common/test/wm_shell_test_api.h [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/wm/overview/window_selector_controller.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/wm_shell.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/common/wm_shell.h [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/focus_cycler_unittest.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/metrics/user_metrics_recorder.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/mus/network_connect_delegate_mus.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/mus/test/wm_test_helper.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/root_window_controller_unittest.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/shell.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/shell.h [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/system/chromeos/screen_layout_observer.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/test/BUILD.gn [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/test/ash_test_base.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/test/ash_test_helper.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/test/status_area_widget_test_helper.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/chrome/browser/chromeos/login/ui/webui_login_view.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/chrome/browser/chromeos/power/login_lock_state_notifier.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc [modify] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7 commit 5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7 Author: sky <sky@chromium.org> Date: Tue Mar 21 19:35:08 2017 Move even more from WmShell to Shell I don't believe any of these are related, just the next set in alphabetical order. BUG= 687660 TEST=covered by tests R=jamescook@chromium.org, reveman@chromium.org TBR=reveman@chromium.org Review-Url: https://codereview.chromium.org/2766543002 Cr-Commit-Position: refs/heads/master@{#458511} [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/accelerators/accelerator_commands.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/accelerators/debug_commands.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/focus_cycler.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/frame/caption_buttons/frame_caption_button_container_view.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/frame/caption_buttons/frame_caption_button_container_view_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/metrics/pointer_metrics_recorder.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/metrics/pointer_metrics_recorder_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/mojo_interface_factory.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/shelf/shelf_layout_manager.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/system/chromeos/brightness/tray_brightness.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/system/chromeos/brightness/tray_brightness_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/system/chromeos/media_security/multi_profile_media_tray_item.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/system/overview/overview_button_tray.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/system/user/user_card_view.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm/mru_window_tracker_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm/overview/window_selector_controller.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm/window_cycle_controller.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm/window_positioner.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm/window_positioner.h [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm_shell.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/common/wm_shell.h [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/display/display_util.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/shell.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/shell.h [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/system/chromeos/power/tablet_power_button_controller.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/system/chromeos/rotation/tray_rotation_lock.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/wm/ash_focus_rules.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/ash/wm/power_button_controller.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/chromeos/extensions/wallpaper_private_api.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/ash/window_positioner_unittest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/components/arc/intent_helper/arc_intent_helper_bridge.cc [modify] https://crrev.com/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7/components/exo/wm_helper_ash.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6 commit 5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6 Author: sky <sky@chromium.org> Date: Wed Mar 22 04:31:23 2017 Move yet more from WmShell to Shell BUG= 687660 TEST=covered by tests R=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2761373002 Cr-Commit-Position: refs/heads/master@{#458625} [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/accelerators/accelerator_filter_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/aura/wm_shell_aura.h [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/mojo_interface_factory.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/session/session_state_observer.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/shelf/shelf_layout_manager.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/shelf/shelf_locking_manager.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/shelf/shelf_widget.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/shelf/shelf_window_watcher_item_delegate.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/shelf/wm_shelf.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/chromeos/media_security/multi_profile_media_tray_item.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/chromeos/network/tray_vpn.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/chromeos/palette/palette_tray.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/chromeos/settings/tray_settings.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/date/date_default_view.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/overview/overview_button_tray.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/tiles/tiles_default_view.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/tray/tray_popup_utils.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/user/login_status.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/user/tray_user.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/user/tray_user_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/user/user_card_view.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/user/user_view.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/test/test_session_controller_client.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/test/test_shelf_delegate.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/test/test_system_tray_delegate.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wallpaper/wallpaper_view.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wm/container_finder.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wm/overview/window_selector_controller.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wm/system_modal_container_layout_manager.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wm/window_cycle_controller.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wm_shell.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/common/wm_shell.h [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/metrics/user_metrics_recorder.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/metrics/user_metrics_recorder_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/mus/shelf_delegate_mus.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/mus/system_tray_delegate_mus.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/mus/test/wm_test_base.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/root_window_controller.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/root_window_controller_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/shell.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/shell.h [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/shell/app_list.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/shell/content/client/shell_browser_main_parts.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/shell/window_type_launcher.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/shell/window_watcher.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/shell_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/system/chromeos/power/power_event_observer.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/system/chromeos/power/tablet_power_button_controller.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/system/chromeos/power/video_activity_notifier.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/test/ash_test_base.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/test/ash_test_helper.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/test/shell_test_api.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/test/shell_test_api.h [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/wm/ash_focus_rules_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/wm/event_client_impl.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/wm/power_button_controller.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/ash/wm/workspace_controller_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/launcher/launcher_context_menu.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc [modify] https://crrev.com/5ad143ad7e9fea28bd87d3d64eef36958d8aa8b6/chrome/test/base/view_event_test_platform_part_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b45ed88b90be5c3499158e199a2b89148afb35e commit 5b45ed88b90be5c3499158e199a2b89148afb35e Author: sky <sky@chromium.org> Date: Mon Mar 27 02:54:23 2017 Promotes more accessors from WmShell to Shell BUG= 687660 TEST=covered by tests R=msw@chromium.org,wez@chromium.org, reveman@chromium.org TBR=reveman@chromium.org Review-Url: https://codereview.chromium.org/2775973002 Cr-Commit-Position: refs/heads/master@{#459692} [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/accelerators/accelerator_interactive_uitest_chromeos.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/keyboard/keyboard_ui.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/mojo_interface_factory.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/bluetooth/tray_bluetooth_helper.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/enterprise/tray_enterprise.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/network/tray_network.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/network/tray_vpn.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/network/vpn_list_view.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/screen_security/screen_capture_tray_item.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/screen_security/screen_share_tray_item.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/screen_security/screen_tray_item_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/session/logout_button_tray.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/session/logout_confirmation_controller.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/session/tray_session_length_limit.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/system_clock_observer.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/chromeos/tray_tracing.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/date/date_default_view.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/date/tray_date.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/date/tray_system_info.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/ime/tray_ime_chromeos.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/ime/tray_ime_chromeos_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/overview/overview_button_tray.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/tiles/tiles_default_view.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/tray/system_tray_controller.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/tray_accessibility.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/system/user/tray_user.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/wallpaper/wallpaper_view.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/wm_shell.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/common/wm_shell.h [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/shell.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/shell.h [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/system/chromeos/power/power_event_observer.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/wm/gestures/overview_gesture_handler.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/wm/gestures/overview_gesture_handler_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/ash/wm/window_cycle_event_filter_aura.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/chrome/browser/chromeos/net/DEPS [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/chrome/browser/chromeos/net/network_portal_notification_controller.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/chrome/browser/chromeos/ui/screen_capture_notification_ui_chromeos.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/chrome/browser/ui/ash/multi_user/user_switch_util.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/components/exo/wm_helper_ash.cc [modify] https://crrev.com/5b45ed88b90be5c3499158e199a2b89148afb35e/remoting/host/disconnect_window_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e1148fba194af58c68f064be85a02ac5abafb56 commit 9e1148fba194af58c68f064be85a02ac5abafb56 Author: sky <sky@chromium.org> Date: Fri Mar 31 20:59:07 2017 Moves couple of WmShell methods to standalone functions Specifically GetActiveWindow(), GetFocusedWindow() and GetCaptureWindow(). BUG= 687660 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2787363002 Cr-Commit-Position: refs/heads/master@{#461224} [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/aura/wm_shell_aura.h [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/accelerators/accelerator_commands.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/accelerators/debug_commands.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/focus_cycler.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/fullscreen_window_finder.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/immersive_context_ash.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/mru_window_tracker.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/system_modal_container_layout_manager.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/window_positioner.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/window_positioning_utils.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/common/wm_shell.h [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/mus/accelerators/accelerator_controller_registrar.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/wm/window_util.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/ash/wm/window_util.h [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/chrome/browser/chromeos/arc/boot_phase_monitor/arc_instance_throttle.cc [modify] https://crrev.com/9e1148fba194af58c68f064be85a02ac5abafb56/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5fd122629a18236e1458f79f0785a49ce0ab707 commit e5fd122629a18236e1458f79f0785a49ce0ab707 Author: sky <sky@chromium.org> Date: Wed Apr 12 18:43:23 2017 Removes ShellPort::IsRunningInMash() And converts to usage of Shell::GetAshConfig(). BUG= 687660 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2815043002 Cr-Commit-Position: refs/heads/master@{#464095} [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/accelerators/accelerator_filter_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/aura/shell_port_classic.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/aura/shell_port_classic.h [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/autoclick/autoclick_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/display/display_configuration_controller_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/laser/laser_pointer_controller_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/metrics/user_metrics_recorder_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/mus/bridge/shell_port_mash.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/mus/bridge/shell_port_mash.h [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/root_window_controller.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/root_window_controller_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/rotator/screen_rotation_animator_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/screen_util_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shelf/shelf_button_pressed_metric_tracker_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shelf/shelf_tooltip_manager_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shelf/shelf_window_watcher.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shelf/wm_shelf.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shell.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shell_port.h [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/shell_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/system/ime/tray_ime_chromeos_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/system/power/power_event_observer.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/system/web_notification/web_notification_tray_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/test/ash_test.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/test/ash_test_base.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/tooltips/tooltip_controller_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/immersive_fullscreen_controller_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/system_modal_container_layout_manager.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/system_modal_container_layout_manager_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/toplevel_window_event_handler_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/window_manager_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/workspace/workspace_event_handler_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm/workspace/workspace_window_resizer_unittest.cc [modify] https://crrev.com/e5fd122629a18236e1458f79f0785a49ce0ab707/ash/wm_window.cc
For the most part all the code that is the same between ShellPort* has moved to Shell. Calling this done.
Comment 1 by bugdroid1@chromium.org
, Mar 8 2017