New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687658 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 671246



Sign in to add a comment

Remove WmLookup

Project Member Reported by sky@chromium.org, Feb 1 2017

Issue description

It's no longer needed.
 

Comment 1 by sky@chromium.org, Feb 27 2017

More specifically:

GetWindowForWidget() is the same for both aura and mus. So, said function should just removed and the calling sites can do what the functions is doing (it's a single line).

GetRootWindowControllerWithDisplayId() is different between the two implementations. I recommend moving this function onto Shell and having it delegate to WmShell. This way callers are calling the function directly on Shell.

Comment 2 by sky@chromium.org, Feb 28 2017

Owner: thanhph@chromium.org
Status: Assigned (was: Untriaged)
More specifically for GetRootWindowControllerWithDisplayId() we should move this function to Shell. And change call sites to use Shell. Shell's implementation will call into WmShell::GetRootWindowForDisplayId(). e.g.

Shell::GetRootWindowControllerWithDisplayId(int64_t display_id) {
  WmWindow* root_window = wm_shell_->GetRootWindowControllerWithDisplayId(display_id);
  return root_window ? root_window->GetRootWindowController() : nullptr;
}
Status: Fixed (was: Assigned)
https://codereview.chromium.org/2726823003/

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment