And use aura::LayoutManager directly
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7aa2519f44df0777bb5e457ed01cc4788a931705 commit 7aa2519f44df0777bb5e457ed01cc4788a931705 Author: yiyix <yiyix@chromium.org> Date: Fri Mar 10 16:42:00 2017 Update window_parenting_utils to use aura::window instead of WmWindow. BUG= 687657 Review-Url: https://codereview.chromium.org/2737213002 Cr-Commit-Position: refs/heads/master@{#456080} [modify] https://crrev.com/7aa2519f44df0777bb5e457ed01cc4788a931705/ash/common/wm/default_state.cc [modify] https://crrev.com/7aa2519f44df0777bb5e457ed01cc4788a931705/ash/common/wm/dock/docked_window_layout_manager.cc [modify] https://crrev.com/7aa2519f44df0777bb5e457ed01cc4788a931705/ash/common/wm/dock/docked_window_resizer.cc [modify] https://crrev.com/7aa2519f44df0777bb5e457ed01cc4788a931705/ash/common/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/7aa2519f44df0777bb5e457ed01cc4788a931705/ash/common/wm/panels/panel_window_resizer.cc [modify] https://crrev.com/7aa2519f44df0777bb5e457ed01cc4788a931705/ash/common/wm/window_parenting_utils.cc [modify] https://crrev.com/7aa2519f44df0777bb5e457ed01cc4788a931705/ash/common/wm/window_parenting_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f084ef51daaddb8a090d865dfc904ca1b8335a0 commit 9f084ef51daaddb8a090d865dfc904ca1b8335a0 Author: yiyix <yiyix@chromium.org> Date: Wed Mar 15 15:36:42 2017 Refactor PanelLayoutManager to use aura::LayoutManager BUG= 687657 Review-Url: https://codereview.chromium.org/2746873003 Cr-Commit-Position: refs/heads/master@{#457090} [modify] https://crrev.com/9f084ef51daaddb8a090d865dfc904ca1b8335a0/ash/common/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/9f084ef51daaddb8a090d865dfc904ca1b8335a0/ash/common/wm/panels/panel_layout_manager.h [modify] https://crrev.com/9f084ef51daaddb8a090d865dfc904ca1b8335a0/ash/common/wm/wm_snap_to_pixel_layout_manager.cc [modify] https://crrev.com/9f084ef51daaddb8a090d865dfc904ca1b8335a0/ash/root_window_controller.cc [modify] https://crrev.com/9f084ef51daaddb8a090d865dfc904ca1b8335a0/ash/test/wm_window_test_api.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3919a2d21a0c3df90ab7077aa6ebee97262dfd29 commit 3919a2d21a0c3df90ab7077aa6ebee97262dfd29 Author: sky <sky@chromium.org> Date: Mon May 08 15:52:27 2017 chromeos: Converts WorkspaceLayoutManager to aura::LayoutManager BUG= 687657 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2861243003 Cr-Commit-Position: refs/heads/master@{#469993} [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/root_window_controller.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/always_on_top_controller.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/always_on_top_controller_unittest.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/fullscreen_window_finder.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/fullscreen_window_finder.h [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/mru_window_tracker.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/switchable_windows.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/switchable_windows.h [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/workspace/workspace_layout_manager.h [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/workspace_controller.cc [modify] https://crrev.com/3919a2d21a0c3df90ab7077aa6ebee97262dfd29/ash/wm/workspace_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97f9a74388f0a4ef84ac44a9e811dbb106c35275 commit 97f9a74388f0a4ef84ac44a9e811dbb106c35275 Author: sky <sky@chromium.org> Date: Tue May 09 05:14:31 2017 Converts remaining usage of WmLayoutManager to aura::LayoutManager Yay! BUG= 687657 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2871813002 Cr-Commit-Position: refs/heads/master@{#470233} [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/BUILD.gn [delete] https://crrev.com/6b2241e2042fe5365c84d84828c8db3a3625c18f/ash/aura/aura_layout_manager_adapter.cc [delete] https://crrev.com/6b2241e2042fe5365c84d84828c8db3a3625c18f/ash/aura/aura_layout_manager_adapter.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/keyboard/keyboard_observer_register.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/keyboard/keyboard_observer_register.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/root_window_controller.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/root_window_controller.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/root_window_controller_unittest.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/shelf/shelf_widget.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/shell.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/shell.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/shell_observer.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/shell_port.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/shell_port.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/system/status_area_layout_manager.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/system/status_area_layout_manager.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/lock_layout_manager.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/lock_layout_manager.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/panels/panel_layout_manager.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/root_window_layout_manager.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/root_window_layout_manager.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/system_modal_container_layout_manager.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/system_modal_container_layout_manager.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/system_modal_container_layout_manager_unittest.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/window_positioning_utils.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/wm_snap_to_pixel_layout_manager.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/wm_snap_to_pixel_layout_manager.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm/workspace/workspace_layout_manager.h [delete] https://crrev.com/6b2241e2042fe5365c84d84828c8db3a3625c18f/ash/wm_layout_manager.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm_window.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/ash/wm_window.h [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/chrome/browser/chromeos/login/ui/webui_login_view.cc [modify] https://crrev.com/97f9a74388f0a4ef84ac44a9e811dbb106c35275/chrome/browser/chromeos/login/ui/webui_login_view.h
Comment 1 by sky@chromium.org
, Feb 1 2017