And use aura::Window directly. There are a handful of differences that will have to be dealt with before it can be removed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b22d05a5146584837929c70b04f87402156e649 commit 1b22d05a5146584837929c70b04f87402156e649 Author: sky <sky@chromium.org> Date: Fri Apr 07 22:39:30 2017 Removes couple of methods from WmWindow Code is changed to use aura directly. BUG= 687656 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2799993003 Cr-Commit-Position: refs/heads/master@{#463024} [modify] https://crrev.com/1b22d05a5146584837929c70b04f87402156e649/ash/common/accelerators/debug_commands.cc [modify] https://crrev.com/1b22d05a5146584837929c70b04f87402156e649/ash/common/devtools/ash_devtools_dom_agent.cc [modify] https://crrev.com/1b22d05a5146584837929c70b04f87402156e649/ash/common/devtools/ash_devtools_unittest.cc [modify] https://crrev.com/1b22d05a5146584837929c70b04f87402156e649/ash/common/wm/overview/window_grid.cc [modify] https://crrev.com/1b22d05a5146584837929c70b04f87402156e649/ash/common/wm/overview/window_selector_item.cc [modify] https://crrev.com/1b22d05a5146584837929c70b04f87402156e649/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/1b22d05a5146584837929c70b04f87402156e649/ash/common/wm_window.cc [modify] https://crrev.com/1b22d05a5146584837929c70b04f87402156e649/ash/common/wm_window.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10784779e17f9d143d5f57c7ff902ee7efc0cc81 commit 10784779e17f9d143d5f57c7ff902ee7efc0cc81 Author: sky <sky@chromium.org> Date: Sat Apr 08 00:55:20 2017 Moves WmWindow::GetInternalWidget() into a standalone function BUG= 687656 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2798333005 Cr-Commit-Position: refs/heads/master@{#463084} [modify] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/BUILD.gn [modify] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/common/accelerators/debug_commands.cc [modify] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/common/devtools/ash_devtools_unittest.cc [modify] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/common/focus_cycler.cc [modify] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/common/wm_window.cc [modify] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/common/wm_window.h [add] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/wm/widget_finder.cc [add] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/wm/widget_finder.h [modify] https://crrev.com/10784779e17f9d143d5f57c7ff902ee7efc0cc81/ash/wm/window_mirror_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6f4a61a3902af614f0a1176fb31b4d8914d2339 commit e6f4a61a3902af614f0a1176fb31b4d8914d2339 Author: sky <sky@chromium.org> Date: Wed Apr 12 23:52:18 2017 Removes a couple more functions from WmWindow I started removing GetChildByShellWindowId(), but left it in places that would have resulted in lots of unnecessary back and forth between aura::Window and WmWindow. BUG= 687656 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2814243002 Cr-Commit-Position: refs/heads/master@{#464211} [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/devtools/ash_devtools_unittest.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/mus/test/ash_test_impl_mus.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/mus/top_level_window_factory.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/mus/window_manager.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/root_window_controller.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/shelf/shelf_widget.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/system/status_area_widget.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/system/tray/system_tray.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/system/tray/tray_event_filter.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/always_on_top_controller.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/container_finder.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/container_finder_unittest.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/default_state.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/focus_rules.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/maximize_mode/workspace_backdrop_delegate.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/overview/window_selector.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/switchable_windows.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/system_modal_container_layout_manager.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/window_positioning_utils.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/wm_snap_to_pixel_layout_manager.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/workspace/phantom_window_controller.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/workspace/workspace_window_resizer.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm/workspace_controller.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm_window.cc [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/ash/wm_window.h [modify] https://crrev.com/e6f4a61a3902af614f0a1176fb31b4d8914d2339/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1 commit fa0a83ccea48b98b3c8a7facd068a41bc92f21f1 Author: sky <sky@chromium.org> Date: Mon Apr 17 22:48:48 2017 Makes functions in container_finder take aura::Window BUG= 687656 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2826453003 Cr-Commit-Position: refs/heads/master@{#465049} [modify] https://crrev.com/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1/ash/mus/top_level_window_factory.cc [modify] https://crrev.com/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1/ash/mus/window_manager.cc [modify] https://crrev.com/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1/ash/root_window_controller.cc [modify] https://crrev.com/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1/ash/system/tray/system_tray.cc [modify] https://crrev.com/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1/ash/system/tray/tray_event_filter.cc [modify] https://crrev.com/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1/ash/wm/container_finder.cc [modify] https://crrev.com/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1/ash/wm/container_finder.h [modify] https://crrev.com/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1/ash/wm/container_finder_unittest.cc [modify] https://crrev.com/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1/ash/wm/stacking_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3 commit 3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3 Author: sky <sky@chromium.org> Date: Tue Apr 18 18:46:48 2017 chromeos: converts ash devtools to aura::Window BUG= 687656 TEST=covered by tests R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2821213002 Cr-Commit-Position: refs/heads/master@{#465299} [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ash/devtools/ash_devtools_css_agent.cc [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ash/devtools/ash_devtools_css_agent.h [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ash/devtools/ash_devtools_dom_agent.cc [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ash/devtools/ash_devtools_dom_agent.h [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ash/devtools/ash_devtools_unittest.cc [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ash/test/ash_test_base.cc [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ash/test/ash_test_base.h [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/chromecast/graphics/cast_focus_client_aura.cc [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/chromecast/graphics/cast_focus_client_aura.h [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ui/wm/core/default_activation_client.cc [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ui/wm/core/default_activation_client.h [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ui/wm/core/focus_controller.cc [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ui/wm/core/focus_controller.h [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ui/wm/core/window_util.cc [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ui/wm/core/window_util.h [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ui/wm/public/activation_client.cc [modify] https://crrev.com/3e82c5b9d88086ead8bbbd122eef8c1b5d45f5e3/ui/wm/public/activation_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f14333c9889b233634b98673489f1268ea722034 commit f14333c9889b233634b98673489f1268ea722034 Author: sky <sky@chromium.org> Date: Tue Apr 18 22:21:01 2017 chromeos: converts DragImageViewTest to AshTestBase And removes usage of WmWindow. BUG= 707057 , 687656 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2828543003 Cr-Commit-Position: refs/heads/master@{#465393} [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/drag_drop/drag_drop_controller.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/drag_drop/drag_image_view.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/drag_drop/drag_image_view.h [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/drag_drop/drag_image_view_unittest.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/mus/window_manager.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/shelf/shelf_view.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/test/ash_test_base.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/test/ash_test_base.h
+varkha, see blocking bugs for areas that are already claimed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad3d9551c524430d184c1d62a128576bcb2dd452 commit ad3d9551c524430d184c1d62a128576bcb2dd452 Author: msw <msw@chromium.org> Date: Thu May 18 21:23:36 2017 mash: remove more shell/shelf WmWindow usage. Eliminate Shell::GetWmRootWindowForNewWindows(). Convert ShellPort::Get*RootWindow*() to aura::Window. (use Shell::GetPrimaryRootWindow() instead in many places) Convert ScopedRootWindowForNewWindows (etc.) to aura::Window. Convert WmShelf::ForWindow to take aura::Window. Cleanup some helpers and misc WmWindow usage. BUG= 722551 , 687656 TEST=Automated; no behavior changes R=jamescook@chromium.org,xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2886253002 Cr-Commit-Position: refs/heads/master@{#472934} [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/accelerators/exit_warning_handler.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/app_list/app_list_delegate_impl.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/aura/shell_port_classic.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/aura/shell_port_classic.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/drag_drop/drag_drop_tracker_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/first_run/first_run_helper_impl.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/metrics/user_metrics_recorder.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/accelerators/accelerator_controller_registrar.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/bridge/shell_port_mash.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/bridge/shell_port_mash.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/top_level_window_factory.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/window_manager.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/window_manager.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/root_window_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/root_window_controller_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/scoped_root_window_for_new_windows.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/scoped_root_window_for_new_windows.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_view.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_widget_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_window_watcher.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/wm_shelf.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/wm_shelf.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell/window_watcher.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell_port.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell_port.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/system/palette/palette_utils.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/system/session/logout_confirmation_dialog.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/system/toast/toast_overlay.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/system/tray/system_tray_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/test/ash_test_base.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/drag_window_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/immersive_context_ash.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/mru_window_tracker.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/overview/window_grid.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/overview/window_selector.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/system_modal_container_layout_manager_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_animations.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_cycle_list.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_positioner.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_positioner_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_positioning_utils.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_util.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/workspace_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/chromeos/accessibility/chromevox_panel.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/chromeos/first_run/steps/tray_step.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/chromeos/login/login_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/chromeos/ui/accessibility_cursor_ring_layer.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/shelf_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/system_tray_client_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/515b434684c2225f869b1bfe2a477d5cd479d005 commit 515b434684c2225f869b1bfe2a477d5cd479d005 Author: varkha <varkha@chromium.org> Date: Fri May 26 23:21:27 2017 [mus+ash] Removes WmWindow from ash RootWindowcontroller implementation Moves WmWindow methods SetChildrenUseExtendedHitRegion and ShouldUseExtendedHitRegion into window_util (as SetChildrenUseExtendedHitRegionForWindow and ShouldUseExtendedHitRegionForWindow) and adds kChildrenUseExtendedHitRegion bool property that can be set on a container to use an easy targeter. BUG= 687656 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2904273002 Cr-Commit-Position: refs/heads/master@{#475181} [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/mus/non_client_frame_controller.cc [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/root_window_controller.cc [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/root_window_controller.h [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/shelf/shelf_window_targeter.cc [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/shelf/shelf_window_targeter.h [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/wm/window_properties.cc [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/wm/window_properties.h [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/wm/window_util.cc [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/wm/window_util.h [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/wm_window.cc [modify] https://crrev.com/515b434684c2225f869b1bfe2a477d5cd479d005/ash/wm_window.h
Taking over this. Final installment in https://codereview.chromium.org/2919533002 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1 commit c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1 Author: varkha <varkha@chromium.org> Date: Wed May 31 19:09:15 2017 [mus+ash] Removes WmWindow from ash (app_list, frame, metrics, etc.) Removes WmWindow from ash (app_list, frame, metrics, session, shared, system, ash/test, wallpaper, ash/wm/maximize_mode, c/b/ui/ash) With this CL the last places where WmWindow / wm_window.h are used are: ash/aura/shell_port_classic.* ash/mus/bridge/shell_port_mash.* ash/root_window_controller.* ash/shell.cc ash/shell_port.* ash/wm_transient_window_observer.h ash/wm_window.* BUG= 687656 TEST=None (refactoring) TBR=reveman@chromium.org (for trivial changes to components/exo files) Review-Url: https://codereview.chromium.org/2908333003 Cr-Commit-Position: refs/heads/master@{#475972} [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/accelerators/exit_warning_handler.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/app_list/app_list_delegate_impl.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/display/screen_position_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/drag_drop/drag_drop_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/drag_drop/drag_drop_tracker_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/first_run/first_run_helper_impl.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/frame/custom_frame_view_ash.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/frame/header_painter_util.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/frame/header_view.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/high_contrast/high_contrast_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/metrics/pointer_metrics_recorder.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/metrics/pointer_metrics_recorder_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/metrics/user_metrics_recorder.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/metrics/user_metrics_recorder_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/mus/disconnected_app_handler.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/mus/frame/detached_title_area_renderer.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/mus/top_level_window_factory.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/mus/window_manager.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/screen_util.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/shared/immersive_fullscreen_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/shared/immersive_fullscreen_controller.h [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/shell/window_watcher.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/shell_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/system/session/logout_confirmation_dialog.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/system/status_area_widget_delegate.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/system/tray/system_tray_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/system/tray/system_tray_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/system/user/user_view.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/system/web_notification/ash_popup_alignment_delegate.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/test/ash_test_base.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/test/ash_test_helper.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/test/test_shell_delegate.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wallpaper/wallpaper_widget_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wallpaper/wallpaper_widget_controller.h [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wm/immersive_context_ash.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wm/lock_action_handler_layout_manager.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wm/maximize_mode/maximize_mode_event_handler.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wm/panels/panel_frame_view.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wm/window_util.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wm/window_util.h [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wm_window.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ash/wm_window.h [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/chromeos/accessibility/chromevox_panel.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/chromeos/login/login_browsertest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/chromeos/ui/accessibility_cursor_ring_layer.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/window_sizer/window_sizer_ash.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/components/exo/touch_unittest.cc [modify] https://crrev.com/c8621dd6ab0c3c023c24eba66b8ba64c6f1694f1/ui/aura/mus/property_utils.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59679634e6846617095b88b22c5be83f951fedbe commit 59679634e6846617095b88b22c5be83f951fedbe Author: varkha <varkha@chromium.org> Date: Thu Jun 01 00:42:05 2017 [mus+ash] removes WmWindow, wm_window.h and wm_window.cc This CL removes the last few places where WmWindow was used in ash/shell. BUG= 687656 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2919533002 Cr-Commit-Position: refs/heads/master@{#476115} [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/BUILD.gn [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/aura/shell_port_classic.cc [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/aura/shell_port_classic.h [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/mus/bridge/shell_port_mash.cc [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/mus/bridge/shell_port_mash.h [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/root_window_controller.cc [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/root_window_controller.h [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/shell.cc [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/shell_port.cc [modify] https://crrev.com/59679634e6846617095b88b22c5be83f951fedbe/ash/shell_port.h [delete] https://crrev.com/59f7dd73152443a49cc70c90266aab5521932468/ash/wm_transient_window_observer.h [delete] https://crrev.com/59f7dd73152443a49cc70c90266aab5521932468/ash/wm_window.cc [delete] https://crrev.com/59f7dd73152443a49cc70c90266aab5521932468/ash/wm_window.h
Comment 1 by bugdroid1@chromium.org
, Apr 7 2017