New issue
Advanced search Search tips

Issue 687654 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 671246



Sign in to add a comment

Replace WmWindowObserver with aura::WindowObserver

Project Member Reported by sky@chromium.org, Feb 1 2017

Issue description

There is no reason for both at this point.
 

Comment 1 by msw@chromium.org, Feb 17 2017

Owner: msw@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13fbda637196d8a45059840cfd285cd7c3d85124

commit 13fbda637196d8a45059840cfd285cd7c3d85124
Author: msw <msw@chromium.org>
Date: Sat Feb 18 17:00:21 2017

Replace WmWindowObserver with aura::WindowObserver.

Also, some cleanup, mostly around ShelfWindowWatcher:
-Convert most ShelfWindowWatcher WmWindow use to aura::Window.
-Use aura::client::ActivationChangeObserver in ShelfWindowWatcher.
-Persist mash default shelf item type (app) workaround from WmWindow.

BUG= 687654 
TEST=No behavior changes
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2699033002
Cr-Commit-Position: refs/heads/master@{#451467}

[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/BUILD.gn
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/devtools/ash_devtools_dom_agent.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/devtools/ash_devtools_dom_agent.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/shelf/shelf_window_watcher.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/shelf/shelf_window_watcher.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/test/test_shelf_delegate.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/test/test_shelf_delegate.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wallpaper/wallpaper_widget_controller.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wallpaper/wallpaper_widget_controller.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/always_on_top_controller.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/always_on_top_controller.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/dock/docked_window_layout_manager.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/lock_layout_manager.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/lock_layout_manager.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/maximize_mode/maximize_mode_window_manager.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/maximize_mode/workspace_backdrop_delegate.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/mru_window_tracker.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/mru_window_tracker.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/overview/window_grid.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/overview/window_selector.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/overview/window_selector.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/root_window_layout_manager.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/system_modal_container_layout_manager.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/window_cycle_list.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/window_cycle_list.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/window_dimmer.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/window_dimmer.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/window_positioning_utils.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/wm_toplevel_window_event_handler.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/workspace/multi_window_resize_controller.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/workspace/workspace_window_resizer.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/workspace_controller.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm/workspace_controller.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm_window.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm_window.h
[delete] https://crrev.com/98a1e01f4f58d073314620488e4563bb1cfee39d/ash/common/wm_window_observer.h
[delete] https://crrev.com/98a1e01f4f58d073314620488e4563bb1cfee39d/ash/common/wm_window_tracker.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm_window_unittest.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/common/wm_window_user_data.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/display/screen_orientation_controller_chromeos.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/root_window_controller.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/shelf/shelf_window_targeter.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/shelf/shelf_window_targeter.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/wm/screen_pinning_controller.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/wm/video_detector.cc
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/ash/wm/video_detector.h
[modify] https://crrev.com/13fbda637196d8a45059840cfd285cd7c3d85124/chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc

Comment 3 by msw@chromium.org, Feb 19 2017

Status: Fixed (was: Started)

Sign in to add a comment