New issue
Advanced search Search tips

Issue 687652 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Record the network quality using UMA when it is recomputed

Project Member Reported by tbansal@chromium.org, Feb 1 2017 
Currently, Network Quality Estimator (NQE) records UMA on effective connection type, RTTs, and bandwidth on main frame requests. This does not work with the Cronet embedders. Instead, NQE should record the UMA every time it recomputes the network quality, and move away from using the main frame flag set on the request.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7372751e9dcfb0479753f0019acded296873504d

commit 7372751e9dcfb0479753f0019acded296873504d
Author: tbansal <tbansal@chromium.org>
Date: Wed Feb 01 18:59:15 2017

Add NetworkQualityEstimator (NQE) UMA when ECT is computed

Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT)
is computed. This new UMA is logged every time ECT is recomputed. This
ensures that the UMA will be logged for Cronet embedders too, and
reduces NQE's dependence on main frame flag.

BUG= 687652 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2657093002
Cr-Commit-Position: refs/heads/master@{#447566}

[modify] https://crrev.com/7372751e9dcfb0479753f0019acded296873504d/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/7372751e9dcfb0479753f0019acded296873504d/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/7372751e9dcfb0479753f0019acded296873504d/tools/metrics/histograms/histograms.xml

Comment 2 by tbansal@chromium.org, Feb 6 2017

Labels: M-58
Status: Fixed (was: Started)

Comment 3 by tbansal@chromium.org, Feb 13 2017

Components: Internals>Network>NetworkQuality

Comment 4 by tbansal@chromium.org, Feb 14 2017

Labels: -nqe
►

Sign in to add a comment