New issue
Advanced search Search tips

Issue 687650 link

Starred by 4 users
Status: Fixed
Owner:
emir...@chromium.org
Closed: Feb 2017
Cc:
niklase@chromium.org
braveyao@chromium.org
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Enable VP9 support in WebRTC HW encoder and decoders

Project Member Reported by emir...@chromium.org, Feb 1 2017 
Currently VP9 HW encoders and decoders are not hooked up for WebRTC use[0][1]. We know that DXVA decoder-for Win- and some ARM chips-for CrOS- have HW decode for VP9. Also, MediaFoundation has VPX encode support using new Intel KBL hardware. As the usage of VP9 is increasing, it would help to enable webrtc to use these HW capabilities. 


[0] https://cs.chromium.org/chromium/src/content/renderer/media/gpu/rtc_video_encoder.cc?rcl=5e61cddf30c3bd3490b86f87ff6ea71bf05f0368&l=37
[1] https://cs.chromium.org/chromium/src/content/renderer/media/gpu/rtc_video_decoder.cc?rcl=5e61cddf30c3bd3490b86f87ff6ea71bf05f0368&l=108
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a70a137b5635e13d60c66d3666d7f6167fe831

commit 33a70a137b5635e13d60c66d3666d7f6167fe831
Author: emircan <emircan@chromium.org>
Date: Wed Feb 01 22:53:28 2017

Enable VP9 support in WebRTC HW encoder and decoders

BUG= 687650 
TEST=Tested on Win laptops(Asus Strix and Lenovo P50) but they do not have
support for VP9 decode. VPX encode is tested with the patch on
https://codereview.chromium.org/2668293002/.

Review-Url: https://codereview.chromium.org/2666273003
Cr-Commit-Position: refs/heads/master@{#447629}

[modify] https://crrev.com/33a70a137b5635e13d60c66d3666d7f6167fe831/content/renderer/media/gpu/rtc_video_decoder.cc
[modify] https://crrev.com/33a70a137b5635e13d60c66d3666d7f6167fe831/content/renderer/media/gpu/rtc_video_encoder.cc

Comment 2 by emir...@chromium.org, Feb 2 2017

Cc: posciak@chromium.org

Comment 3 by emir...@chromium.org, Feb 3 2017

Cc: braveyao@chromium.org
The above CL picks up and make use of the existing VP9 HW encoder and decoders(mentioned in the first post) if there is any, and lays the groundwork for future support. It didn't cause any problems in the bots so far, but I want to make sure that we aren't enabling something that shouldn't. 
braveyao@, can you help checking if this will cause any issue in Android?

Comment 4 by braveyao@chromium.org, Feb 6 2017 

No, it shouldn't. On Android, only VP8 and H264 are listed as supported HW codecs in several places.

Comment 5 by emir...@chromium.org, Feb 6 2017

Status: Fixed (was: Started)
Thanks. Marking this as fixed, feel free to reopen if you come across to any VP9 HW problems.
►

Sign in to add a comment