ash/common/wm_window_property.h was added because at the time we couldn't use the underlying aura properties directly (we had ui::Window, which was not an aura::Window). We've since nuked ui::Window and solely use aura::Window. This means we can remove usage of WmWindowProperty and go back to the aura properties. For example, WmWindowProperty::ALWAYS_ON_TOP is the same as aura::client::kAlwaysOnTopKey. Code that looks like:

window->GetBoolProperty(WmWindowProperty::ALWAYS_ON_TOP)

Should be converted to:

window->aura_window()->GetProperty(aura::client::kAlwaysOnTopKey);

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12aab1f97b16006dbbe8bad1969377040c6da1a

commit a12aab1f97b16006dbbe8bad1969377040c6da1a
Author: yiyix <yiyix@chromium.org>
Date: Fri Mar 03 21:04:34 2017

Remove WmWindowProperty

Since ui::Window is removed and we solely use aura::Window, we can
remove usage of WmWindowPerperty safely and start to use aura window
property instead.

Since this is a refactor, no new test added.

BUG= 687649 

Review-Url: https://codereview.chromium.org/2731663002
Cr-Commit-Position: refs/heads/master@{#454671}

[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/BUILD.gn
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/accelerators/debug_commands.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/shelf/shelf_widget.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/shelf/shelf_window_watcher_item_delegate.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/test/test_shelf_delegate.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/always_on_top_controller.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/container_finder.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/drag_details.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/wm_snap_to_pixel_layout_manager.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm_window.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/common/wm_window.h
[delete] https://crrev.com/795a3d80dd8d970440ac4f2b575b4dbab8db829e/ash/common/wm_window_property.h
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/shell/window_watcher.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/ash/wm/window_mirror_view.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/a12aab1f97b16006dbbe8bad1969377040c6da1a/chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc