New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687641 link

Starred by 1 user
Status: Fixed
Owner:
█ chenwilliam@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: modularize front-end

Project Member Reported by chenwilliam@chromium.org, Feb 1 2017 
Because closure compilation isn't affected by the number of modules anymore, we can decouple "grab-bag" modules such as components. By making modules smaller and more focused, we improve 1) code health of the project and 2) reduce the file size of our dependencies (although the # of deps may increase).

Additional ideas:
- Create a "dependency cleaner" which analyzes if a module no longer needs a particular dependency anymore.
- Inline multiple modules together (to avoid the XHR overhead of fetching an additional file).
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f5fd7ac00d78dc76c72915135bd63c12ed23b9

commit 48f5fd7ac00d78dc76c72915135bd63c12ed23b9
Author: chenwilliam <chenwilliam@chromium.org>
Date: Thu Feb 02 07:17:48 2017

DevTools: move custom formatter setting to SDK

Because it's referenced in runtime, the setting should be defined in SDK
to be consistent with other settings.

BUG= 687641 

Review-Url: https://codereview.chromium.org/2671583003
Cr-Commit-Position: refs/heads/master@{#447714}

[modify] https://crrev.com/48f5fd7ac00d78dc76c72915135bd63c12ed23b9/third_party/WebKit/Source/devtools/front_end/components/module.json
[modify] https://crrev.com/48f5fd7ac00d78dc76c72915135bd63c12ed23b9/third_party/WebKit/Source/devtools/front_end/sdk/module.json
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff55ec036e5bedf34d408384ef37c0755cfcaef

commit 8ff55ec036e5bedf34d408384ef37c0755cfcaef
Author: chenwilliam <chenwilliam@chromium.org>
Date: Fri Feb 03 23:37:54 2017

DevTools: extract NetworkConditionsSelector into its own module

BUG= 687641 

Review-Url: https://codereview.chromium.org/2668413003
Cr-Commit-Position: refs/heads/master@{#448109}

[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/Tests.js
[delete] https://crrev.com/05bd488e584433dabf586586c5d79ee63228ceca/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/components/module.json
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/emulation/module.json
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/externs.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network/module.json
[add] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js
[add] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSettingsTab.js
[add] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkPriorities.js
[add] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network_conditions/module.json
[rename] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/network_conditions/networkConditionsSettingsTab.css
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/resources/module.json
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/front_end/timeline/module.json
[modify] https://crrev.com/8ff55ec036e5bedf34d408384ef37c0755cfcaef/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42660a6022d49d584415ac90314ee288874b508c

commit 42660a6022d49d584415ac90314ee288874b508c
Author: chenwilliam <chenwilliam@chromium.org>
Date: Tue Feb 07 05:49:09 2017

DevTools: extract event_listeners module

I'll f/u to make event_listeners lazy loaded by element & sources.

BUG= 687641 

Review-Url: https://codereview.chromium.org/2678203002
Cr-Commit-Position: refs/heads/master@{#448558}

[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/components/module.json
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/elements/module.json
[rename] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js
[rename] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js
[rename] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/event_listeners/eventListenersView.css
[add] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/event_listeners/module.json
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/externs.js
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/42660a6022d49d584415ac90314ee288874b508c/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6133b51e341dcc55a1b43eebc51ffee3cd0979b8

commit 6133b51e341dcc55a1b43eebc51ffee3cd0979b8
Author: chenwilliam <chenwilliam@chromium.org>
Date: Wed Feb 22 10:28:09 2017

DevTools: extract ObjectUI module from Components

BUG= 687641 

Review-Url: https://codereview.chromium.org/2712513002
Cr-Commit-Position: refs/heads/master@{#451975}

[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/http/tests/inspector/console-cd-completions.html
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/http/tests/inspector/console-completions.html
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/inspector/console/console-big-array.html
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/inspector/local-object-properties-section.html
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-completions-on-call-frame.html
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/Runtime.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/components/module.json
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/event_listeners/module.json
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/extensions/module.json
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/network/JSONView.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/network/module.json
[rename] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/object_ui/CustomPreviewComponent.js
[rename] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js
[rename] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
[rename] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
[rename] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js
[rename] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/object_ui/customPreviewComponent.css
[add] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/object_ui/module.json
[rename] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/object_ui/objectPropertiesSection.css
[rename] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/profiler/module.json
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/resources/module.json
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
[modify] https://crrev.com/6133b51e341dcc55a1b43eebc51ffee3cd0979b8/third_party/WebKit/Source/devtools/scripts/special_case_namespaces.json
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6acb535d91ce5fc01546dc63b07b736e919accbb

commit 6acb535d91ce5fc01546dc63b07b736e919accbb
Author: chenwilliam <chenwilliam@chromium.org>
Date: Wed Mar 22 19:35:02 2017

DevTools: refactor Common.Renderer for DOM nodes

Preparation for:
https://codereview.chromium.org/2714833002/

BUG= 687641 

Review-Url: https://codereview.chromium.org/2728543002
Cr-Commit-Position: refs/heads/master@{#458841}

[modify] https://crrev.com/6acb535d91ce5fc01546dc63b07b736e919accbb/third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html
[modify] https://crrev.com/6acb535d91ce5fc01546dc63b07b736e919accbb/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
[modify] https://crrev.com/6acb535d91ce5fc01546dc63b07b736e919accbb/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/6acb535d91ce5fc01546dc63b07b736e919accbb/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
[modify] https://crrev.com/6acb535d91ce5fc01546dc63b07b736e919accbb/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
[modify] https://crrev.com/6acb535d91ce5fc01546dc63b07b736e919accbb/third_party/WebKit/Source/devtools/front_end/elements/module.json
[modify] https://crrev.com/6acb535d91ce5fc01546dc63b07b736e919accbb/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7

commit 6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7
Author: chenwilliam <chenwilliam@chromium.org>
Date: Sat Apr 08 01:42:59 2017

DevTools: use interface for ObjectUI and make it a non-autostart module

BUG= 687641 

Review-Url: https://codereview.chromium.org/2714833002
Cr-Commit-Position: refs/heads/master@{#463102}

[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/LayoutTests/inspector/local-object-properties-section.html
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/Source/devtools/front_end/audits/module.json
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/Source/devtools/front_end/extensions/module.json
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
[modify] https://crrev.com/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7/third_party/WebKit/Source/devtools/front_end/object_ui/module.json

Comment 7 by chenwilliam@chromium.org, Jul 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment